[1.1.4] ADBScreen - crashes if waitAfterAction set to 0 --- fixed 2018-12-12 build #145

Bug #1741764 reported by Kamil Kliwison on 2018-01-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sikuli
Critical
RaiMan

Bug Description

If waitAfterAction set to 0 on ADBScreen object, after some time application always crashes.

The reason for that is a bug in method ADBDevice.captureDeviceScreenMat() - InputStream stdout is left unclosed.
Calling stdout.close() in finally{} or using Try-with-resources Statement for:
InputStream stdout = device.executeShell("screencap") fixes that issue.

There are more not closed InputStreams in ADBDevice that may cause issues.

RaiMan (raimund-hocke) on 2018-11-19
Changed in sikuli:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → RaiMan (raimund-hocke)
milestone: none → 1.1.4
summary: - [1.1.1] ADBScreen - crashes if waitAfterAction set to 0
+ [1.1.4] ADBScreen - crashes if waitAfterAction set to 0
RaiMan (raimund-hocke) on 2018-12-12
Changed in sikuli:
status: In Progress → Fix Committed
importance: Medium → Critical
summary: - [1.1.4] ADBScreen - crashes if waitAfterAction set to 0
+ [1.1.4] ADBScreen - crashes if waitAfterAction set to 0 --- fixed
+ 2018-12-12 build #145
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers