Avoid loading callback URL whenever possible
Bug #1048177 reported by
Alberto Mardegan
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Online Accounts: Sign-on UI |
Fix Released
|
Critical
|
Alberto Mardegan | ||
Bug Description
In most cases, loading the callback URL should not be necessary: it's enough to capture the fact that we are redirected to it, and and that point we can close the request.
We should make that by default the callback URL is not loaded, and only if it turns out that loading it is necessary for some providers, add a provider-specific option to override the default behaviour. This would also mitigate the effects of bug 1047588.
Related branches
lp:~mardy/signon-ui/skip-final-url
- David King (community): Approve
-
Diff: 71 lines (+28/-3)1 file modifiedsrc/browser-request.cpp (+28/-3)
Revision history for this message
| Alberto Mardegan (mardy) wrote | #1 |
| Changed in online-accounts-signon-ui: | |
| importance: | Undecided → Critical |
| assignee: | nobody → Alberto Mardegan (mardy) |
| status: | New → In Progress |
| Changed in online-accounts-signon-ui: | |
| status: | In Progress → Fix Committed |
| Changed in online-accounts-signon-ui: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Increasing importance, as this change would effectively render bug 1047588 invisible.
The final solution will come from fixing bug 1047191.