Test suite enters an infinite loop when running 'make clean'

[Yann Pouillon]

I'm currently carrying out a testing campaign on various builds of the trunk of SIESTA (revno 646). I want to automate everything as much as possible, in order to avoid human mistakes and schedule the tests when the computer is most available.

I use an out-of-the-box GCC toolchain from an up-to-date Ubuntu 16.04.3 LTS, including GFortran 5.4.0 and GNU Make 4.1.

When running 'make clean' in the Tests/ subdirectory, Make enters an infinite loop likely due to circular include between the makefiles and test.mk.

I would like to discuss the test workflows so that such loops can be removed and the whole test process be made more robust.

[Nick Papior (nickpapior)]

The current idea of the tests is that they should be runned in the Obj/Tests directory. Since this allows one to test different compiled executables.
Could you try in the Obj/Tests directory, at least I can't reproduce this?

However, I think both I speak for me and Alberto in regards of updating the tests for consistency, better checks and ease.

[Yann Pouillon (pouillon)]

I'm running tests from Obj/, or whatever I object directory I use. Could it be related to my renaming it to something else?

[Nick Papior (nickpapior)]

Sorry for my late reply.

Are you in Obj/ directory, or Obj/Tests?

You should only run tests in the Obj/Tests directory (regardless of Obj/ name). I have just checked I can still run without problems?

[Nick Papior (nickpapior)]

Ah, sorry, you already wrote that... Hmm. I can't see how/where it goes wrong...