Activity log for bug #1630827

Date Who What changed Old value New value Message
2016-10-06 01:18:01 Chao Lian bug added bug
2016-10-06 04:05:48 Chao Lian description if ( nbcell == 2 ) then ! Note that we enable the correction if there is an ! external field dipole_correction = fdf_boolean("SlabDipoleCorrection", & .false.) if (acting_efield .and. (.not. dipole_correction)) then if (ionode) write(6,'(/,(a))') . 'efield: SlabDipoleCorrection turned on automatically', . 'efield: when an external electric field is applied.', . 'efield: For backward compatibility, set if to .false.' dipole_correction = .true. endif else dipole_correction = .false. end if This code in m_efield.F always use True to overwrite the dipole_correction, no matter what user set, making it impossible to set it to false. if ( nbcell == 2 ) then          ! Note that we enable the correction if there is an          ! external field          dipole_correction = fdf_boolean("SlabDipoleCorrection",      & .false.)          if (acting_efield .and. (.not. dipole_correction)) then             if (ionode) write(6,'(/,(a))')      . 'efield: SlabDipoleCorrection turned on automatically',      . 'efield: when an external electric field is applied.',      . 'efield: For backward compatibility, set if to .false.'             dipole_correction = .true.          endif       else          dipole_correction = .false.       end if This code in m_efield.F always use True to overwrite the dipole_correction, no matter what user set, making it impossible to set it to false.
2016-10-06 04:06:27 Chao Lian summary DipoleCorrection not working for slab DipoleCorrection is always true for slab
2016-10-06 04:08:14 Chao Lian description if ( nbcell == 2 ) then          ! Note that we enable the correction if there is an          ! external field          dipole_correction = fdf_boolean("SlabDipoleCorrection",      & .false.)          if (acting_efield .and. (.not. dipole_correction)) then             if (ionode) write(6,'(/,(a))')      . 'efield: SlabDipoleCorrection turned on automatically',      . 'efield: when an external electric field is applied.',      . 'efield: For backward compatibility, set if to .false.'             dipole_correction = .true.          endif       else          dipole_correction = .false.       end if This code in m_efield.F always use True to overwrite the dipole_correction, no matter what user set, making it impossible to set it to false. if ( nbcell == 2 ) then          ! Note that we enable the correction if there is an          ! external field          dipole_correction = fdf_boolean("SlabDipoleCorrection",      & .false.)          if (acting_efield .and. (.not. dipole_correction)) then             if (ionode) write(6,'(/,(a))')      . 'efield: SlabDipoleCorrection turned on automatically',      . 'efield: when an external electric field is applied.',      . 'efield: For backward compatibility, set if to .false.'             dipole_correction = .true.          endif       else          dipole_correction = .false.       end if This code in m_efield.F always use True to overwrite the dipole_correction, no matter what user set, making it impossible to set it to false. Version 4.1
2016-10-06 06:52:07 Nick Papior attachment added patch_1630827 https://bugs.launchpad.net/siesta/+bug/1630827/+attachment/4755715/+files/patch_1630827
2016-10-06 06:52:29 Nick Papior siesta: status New Triaged
2016-10-06 06:52:34 Nick Papior siesta: importance Undecided Wishlist
2016-10-06 07:11:15 Nick Papior nominated for series siesta/trunk
2016-10-06 07:11:15 Nick Papior bug task added siesta/trunk
2016-10-06 07:11:15 Nick Papior nominated for series siesta/4.0
2016-10-06 07:11:15 Nick Papior bug task added siesta/4.0
2016-10-06 07:11:15 Nick Papior nominated for series siesta/4.1
2016-10-06 07:11:15 Nick Papior bug task added siesta/4.1
2016-10-06 07:12:49 Nick Papior siesta/4.0: status New Triaged
2016-10-06 07:12:51 Nick Papior siesta/4.1: status New Triaged
2016-10-06 07:12:53 Nick Papior siesta/4.0: importance Undecided Wishlist
2016-10-06 07:12:55 Nick Papior siesta/4.1: importance Undecided Wishlist
2016-10-06 07:12:57 Nick Papior siesta/4.0: assignee Nick Papior (nickpapior)
2016-10-06 07:12:59 Nick Papior siesta/4.1: assignee Nick Papior (nickpapior)
2016-10-06 07:13:01 Nick Papior siesta/trunk: assignee Nick Papior (nickpapior)
2016-10-06 07:25:39 Launchpad Janitor branch linked lp:siesta/4.0
2016-10-06 07:26:47 Launchpad Janitor branch linked lp:siesta/4.1
2016-10-06 07:35:52 Launchpad Janitor branch linked lp:siesta
2016-10-06 07:44:17 Nick Papior siesta/4.0: status Triaged Fix Committed
2016-10-06 07:44:19 Nick Papior siesta/4.1: status Triaged Fix Committed
2016-10-06 07:44:21 Nick Papior siesta/trunk: status Triaged Fix Committed
2016-10-13 08:55:16 Nick Papior siesta/4.1: milestone 4.1-b2
2016-10-13 10:16:37 Nick Papior siesta/4.0: milestone 4.0.1
2016-11-28 13:27:25 Nick Papior siesta/4.1: status Fix Committed Fix Released
2016-11-28 13:28:48 Nick Papior bug task deleted siesta/trunk
2017-02-20 14:40:04 Nick Papior siesta: milestone 4.0.1
2017-07-05 07:04:44 Nick Papior siesta/4.0: status Fix Committed Fix Released
2017-07-05 07:04:46 Nick Papior siesta: status Fix Committed Fix Released