Use icons from system theme [do not hardcode icons]

[Vish]

Binary package hint: shotwell

Shotwell is using icons that are different from the system selected icons. [and the icons are hard-coded]
A few icons are from the system/user-selected theme and a few are not.
This causes inconsistency in the User interface.

It would be reasonable if there are no standard icons and shotwell was using its own icons instead.
But some of the standard icons are not used from the theme.

Icons that are hardcoded are: [with replacements available]

In the toolbar:
Rotate
Crop
Publish

Menubar:
File > Import From Folder...
 > Publish
Photo > Rotate Left
 > Rotate Right
 > Mirror
 > Mark as favorite
 > Hide [better to not use an icon here]

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: shotwell 0.5.0+dfsg-1.1
Uname: Linux 2.6.34-020634-generic i686
Architecture: i386
Date: Thu Jun 10 19:17:52 2010
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Alpha i386 (20091209)
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: shotwell

[Adam Dingle (adam-yorba)]

We have a ticket for this issue at http://trac.yorba.org/ticket/1578 .

[Vish (vish)]

Thanks for finding the upstream bug.

[Andrew (and471)]

Okay the icons that are still needed are:

crop.svg
last-import-roll.png
redeye.png
one-event.png
multiple-events.png
merge.svg

@Vish: Could Humanity help out here? :)

[Danielle Foré (danrabbit)]

Andrew, some of these icons might not be present in most themes. I would suggest trying to find the proper names to use for these icons and supplying them with your package. They should be placed in /usr/share/icons/hicolor in the appropriate folders.

I will try to find the correct names for these icons in the morning if someone hasn't already done it :)

[Andrew (and471)]

@Daniel
Yes that I what I meant when I asked Vish. I meant that he could create the icons that would then be supplied with shotwell as some icons are not supplied in icon themes

[Andrew (and471)]

:)

[Danielle Foré (danrabbit)]

Ah sorry, it was 2 AM and I wasn't thinking straight lol.

[Vish (vish)]

Andrew , I filed this bug so that the icons wouldnt be hard-coded, when there were replacements already available.

Shotwell seems to have changed a bit and it might need more icons.
We'll work on the new icons for shotwell in a separate bug. closing this bug as fixed.

I have one concern though, in the upstream bug and you mention "when I have done the stock icon replacement I shall make a patch" , not sure what you meant there..
If the patch in shotwell is using stock icon names , then there will be a problem in shotwell when other icon themes are used. stock icons are being removed from gnome icon theme 2.30 ,while they are still present in Humanity.
So a heads-up if the patch was using stock icon names :)