Fuel Master postgresql dump is missing

[Andrey Tykhonov]

This bug was introduced by https://review.openstack.org/241271. As the result postgresql dump is absent in a snapshot.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/249152

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/249152
Committed: https://git.openstack.org/cgit/openstack/shotgun/commit/?id=a0bd06508067935f2ae9be2523ed0d1717b995ce
Submitter: Jenkins
Branch: master

commit a0bd06508067935f2ae9be2523ed0d1717b995ce
Author: Andrey Tykhonov <email address hidden>
Date: Tue Nov 24 13:34:03 2015 +0200

    Fix dump for PostgreSQL is missing in a snapshot

    This issue was introduced by
    https://review.openstack.org/241271. Actually the changes in that
    patch doesn't allow to execute a command (or file/dir operation) on a
    local host.

    This patch fixes:

    * execution of a command on a local host (when neither address nor
    hostname is specified)
    * missing dump for PostgreSQL in a snapshot
    * getting network address (address may be absent, but hostname could be
      present, so we need to use hostname in that case)

    Change-Id: Iafecfa458372458963abd1e16890fe225454a612
    Partial-bug: #1519303

[Andrey Tykhonov (atykhonov)]

Why it is confirmed, and why it is re-assigned? There is already proposed fix for it https://review.openstack.org/#/c/249163/. It is reviewed and ready to be merged.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/249163
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=6b1e6f29c667b1a57aada176ac0cf75cfe6fa6d3
Submitter: Jenkins
Branch: master

commit 6b1e6f29c667b1a57aada176ac0cf75cfe6fa6d3
Author: Andrey Tykhonov <email address hidden>
Date: Tue Nov 24 13:51:10 2015 +0200

    Fix dump for PostgreSQL is missing in a snapshot

    This patch:

    * Removes `address` for `local` role. `address` is not required
    anymore for task execution for this role;

    * Fixes missing dump for PostgreSQL;

    * Explicitly specifies `hostname` for a master. As the result we will
    have in a snapshot directory structure like the following:

    - fuel-snapshot
    -- `hostname`
    -- `hostname`/var/
    -- `hostname`/pg_dump/
    -- `node-1`
    -- ...

    Previously (and for now) instead of `hostname`, IP address or
    'localhost' (127.0.0.1) was used.

    Change-Id: I8d9618590d73f93a6957ca80edc363dbd1b43c61
    Depends-on: Iafecfa458372458963abd1e16890fe225454a612
    Closes-bug: #1519303

[Anastasia Palkina (apalkina)]

Verified on ISO #303

VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "303"
  build_id: "303"
  fuel-nailgun_sha: "352548386007399a95a6f21b1fcd9c48a0726325"
  python-fuelclient_sha: "b2bbcdf1c0f38adb34cff01cb6040006911f2ea5"
  fuel-agent_sha: "49bb78675b749d15ae8f0f045dc2b0811777a9d6"
  fuel-nailgun-agent_sha: "a33a58d378c117c0f509b0e7badc6f0910364154"
  astute_sha: "c56dfde2da034151a7e707b381c4cf9d213b4ba2"
  fuel-library_sha: "14576a3dbb3be5e4013c306776dc2eaefe0c15e0"
  fuel-ostf_sha: "9910a4726cbd038c257582b429527e40c4c3cb20"
  fuel-mirror_sha: "dbbe9ddc2c8a336aa7ab62952761bd079e374d1d"
  fuelmenu_sha: "680b720291ff577f4c058cee25f85e563c96312e"
  shotgun_sha: "cacb93cbc28910ff0dc38f30a855efa9af50d8ce"
  network-checker_sha: "d443ef47abeda58d319bc8d33d5005dd09440a02"
  fuel-upgrade_sha: "1e894e26d4e1423a9b0d66abd6a79505f4175ff6"
  fuelmain_sha: "74e9affd54e5a31fd55ed75a3402940dd186a621"