Shellsink crashes if .bash_history_timestamp is empty
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
shellsink |
Fix Committed
|
Undecided
|
Unassigned |
Bug Description
Hello,
shellsink crashes if ${HOME}
Traceback of the issue (after removing the content of .bash_history_
File "/usr/bin/
main()
File "/usr/bin/
client.
File "/usr/bin/
if self.has_
File "/usr/bin/
last_
File "/usr/bin/
old_
ValueError: empty string for float()
Removing that file fixes the issue.
The bug appears to be in line 98 of /usr/bin/
Patch:
Change line 98 of /usr/bin/
if os.path.
to
if os.path.
fixes the bug.
Regards,
Luca Invernizzi
Thanks for the bug report. Revision 36 fixes this. I actually changed it so it should handle any corruption of the history timestamp file, not just a truncated file. The new fix also requires less code and no if statements, so that is good too. I'm considering pushing out a new version of the client to the debian repository this weekend. Expect to see this change in there. Or you can always just use what is in trunk.