init.d script should use --oknodo option

[Sergey Svishchev]

Binary package hint: syslog-ng

Debian policy [1] states:

"The init.d scripts must ensure that they will behave sensibly (i.e., returning success and not starting multiple copies of a service) if invoked with start when the service is already running, or with stop when it isn't, and that they don't kill unfortunately-named user processes. The best way to achieve this is usually to use start-stop-daemon with the --oknodo option."

".../syslog-ng stop" returns 1 when daemon is not running.

[1] http://www.debian.org/doc/debian-policy/ch-opersys.html

[Peter Czanik (pczanik)]

fixed in Ubuntu 11.10

root@ubuntu1110:~# /etc/init.d/syslog-ng stop
 * Stopping system logging syslog-ng [ OK ]
root@ubuntu1110:~# echo $?
0
root@ubuntu1110:~# /etc/init.d/syslog-ng stop
 * Stopping system logging syslog-ng seems to be stopped already
root@ubuntu1110:~# echo $?
0
root@ubuntu1110:~#

[Clint Byrum (clint-fewbar)]

Thanks for the heads up! Closing as Fix Released...

syslog-ng (3.1.1-3) unstable; urgency=low

  * Update initscript not to fail if syslog-ng is already running or stopped.
  * Don't just enable SSL support, but make it really built.
  * Don't leave files behind on remove and purge.

 -- Laszlo Boszormenyi (GCS) <email address hidden> Sat, 29 May 2010 07:38:34 +0000