webhook trigger works even if V query parameter is not specified
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
senlin |
Fix Released
|
High
|
Duc Truong |
Bug Description
According to API documentation, V query parameter for webhook trigger is optional (https:/
V (Optional) query string The webhook implementation version requested.
However, as per discussion with Qiming, the V query parameter should be required:
http://
When sending a webhook trigger request with a X-Auth-Token header and without the V query parameter, the webhook trigger still succeeds:
(openstack) cluster receiver create --cluster mycluster --action CLUSTER_SCALE_OUT --type webhook test-receiver
+------
| Field | Value |
+------
| action | CLUSTER_SCALE_OUT |
| actor | { |
| | "trust_id": "d27dfaa9752549
| | } |
| channel | { |
| | "alarm_url": "http://
| | } |
| cluster_id | 447efe11-
| created_at | 2018-03-
| domain_id | None |
| id | 30ef5c97-
| location | None |
| name | test-receiver |
| params | {} |
| project_id | ce556a7d93c8447
| type | webhook |
| updated_at | None |
| user_id | 1d7de07588dc4b0
+------
stack@sandboxCo
{"action": "fce862ed-
The expected behavior is for the webhook trigger request to return an error when the V query parameter is not specified.
Changed in senlin: | |
assignee: | nobody → Duc Truong (dtruong) |
Changed in senlin: | |
status: | New → Triaged |
importance: | Undecided → High |
summary: |
- webhook trigger does work if V query parameter is not specified + webhook trigger works even if V query parameter is not specified |
description: | updated |
Fix proposed to branch: master /review. openstack. org/557798
Review: https:/