Adopt node failed

[liyi]

Adopt node with body:
{
    "identity": "81c1110c-3931-4b8c-9898-0b97001f5cef",
    "metadata": {},
    "name": "node-adopt",
    "overrides": null,
    "role": "master",
    "snapshot": true,
    "type": "os.nova.server-1.0"
}

API raise exception:
{
  "code": 400,
  "error": {
    "code": 400,
    "message": "Additional properties are not allowed ('preview' was unexpected)",
    "type": "HTTPBadRequest"
  },
  "explanation": "The server could not comply with the request since it is either malformed or otherwise incorrect.",
  "title": "Bad Request"
}

The code https://github.com/openstack/senlin/blob/master/senlin/api/openstack/v1/nodes.py#L78 set the 'preview=False' in body, but NodeAdoptRequest class (https://github.com/openstack/senlin/blob/master/senlin/objects/requests/nodes.py#L113-L123) doesn't contain 'preview'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/485092

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/485092
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=89eb786478ea4c16114b1031bdf8c12844a46c2d
Submitter: Jenkins
Branch: master

commit 89eb786478ea4c16114b1031bdf8c12844a46c2d
Author: liyi <email address hidden>
Date: Wed Jul 19 16:08:48 2017 +0800

    Adopt node failure

    1. 'preview' is not necessary for adopt in API level, if need, we
    can set it node_adopt function in senlin-engin level.
    2. disk_config of server may be None, but AUTO_DISJ_CONFIG is
    boolean.
    3. bdm of server may be None, but BLOCK_DEVICE_MAPPING is list.
    4. config_drive of server may be empty string or None, but
    CONFIG_DRIVE is boolean.

    Change-Id: I76c0d689d7124f70af915f1e3c14c737314fd47f
    Closes-Bug: #1705168

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/senlin 4.0.0.0b3 development milestone.