'enabled' is not supported when cluster policy attach

Bug #1664208 reported by XueFeng Liu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
senlin
Fix Released
High
XueFeng Liu

Bug Description

We have support 'enabled'in client/db when cluster-policy-attach. But we did't use it when policy real attach to a cluster.Need fix this.
root@tecs:/home/openstack/devstack# senlin cluster-policy-attach --help
usage: senlin cluster-policy-attach -p <POLICY> [-e <BOOLEAN>] <NAME or ID>

Attach policy to cluster.

Positional arguments:
  <NAME or ID> Name or ID of cluster to operate on.

Optional arguments:
  -p <POLICY>, --policy <POLICY>
                        ID or name of policy to be attached.
  -e <BOOLEAN>, --enabled <BOOLEAN>
                        Whether the policy should be enabled once attached.
                        Default to enabled.

Changed in senlin:
assignee: nobody → XueFeng Liu (jonnary-liu)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/433188

Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/433188
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=fb240766a2505d5ad527ba314913c90a9f8da6b1
Submitter: Jenkins
Branch: master

commit fb240766a2505d5ad527ba314913c90a9f8da6b1
Author: jonnary <email address hidden>
Date: Mon Feb 13 19:33:36 2017 +0800

    Support 'enabled' in attach callback

    We have supported 'enabled' option in api/db when attaching policy
    to a cluster. This patch supports 'enabled' in attach callback, or else
    we will get bug when we run 'senlin cluster-policy-attach' with
    'enabled'=False.

    Closes-Bug: #1664208
    Change-Id: I75d3eec974bf728c51cd31b2b8c1c31b7e43d1ba

Changed in senlin:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/435463

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (stable/ocata)

Reviewed: https://review.openstack.org/435463
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=dc2e77d6fd3ccf787a68b9666da716a3326422b0
Submitter: Jenkins
Branch: stable/ocata

commit dc2e77d6fd3ccf787a68b9666da716a3326422b0
Author: jonnary <email address hidden>
Date: Mon Feb 13 19:33:36 2017 +0800

    Support 'enabled' in attach callback

    We have supported 'enabled' option in api/db when attaching policy
    to a cluster. This patch supports 'enabled' in attach callback, or else
    we will get bug when we run 'senlin cluster-policy-attach' with
    'enabled'=False.

    Closes-Bug: #1664208
    Change-Id: I75d3eec974bf728c51cd31b2b8c1c31b7e43d1ba
    (cherry picked from commit fb240766a2505d5ad527ba314913c90a9f8da6b1)

tags: added: in-stable-ocata
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin 3.0.0.0rc2

This issue was fixed in the openstack/senlin 3.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin 4.0.0.0b1

This issue was fixed in the openstack/senlin 4.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.