receiver with action 'CLUSTER_CREATE' cannot be triggered successfully

Bug #1652232 reported by lvdongbing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
senlin
Fix Released
High
Qiming Teng

Bug Description

When create a receiver with the 'action' set to 'CLUSTER_CREATE', the receiver can not be triggered
successfully. Because when triggering the webhook(or message), engine will create an action object with the cluster_id of the target cluster of the receiver but not a new one's.
Should we support 'CLUSTER_CREATE' for receiver? Or we should forbid it in create request field.

Revision history for this message
Qiming Teng (tengqim) wrote :

my first reaction is that we should forbid it.

lvdongbing (dbcocle)
Changed in senlin:
assignee: nobody → lvdongbing (dbcocle)
Changed in senlin:
status: New → In Progress
Qiming Teng (tengqim)
Changed in senlin:
importance: Undecided → High
milestone: none → ocata-3
Qiming Teng (tengqim)
Changed in senlin:
assignee: lvdongbing (dbcocle) → Qiming Teng (tengqim)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin (master)

Fix proposed to branch: master
Review: https://review.openstack.org/423601

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin (master)

Reviewed: https://review.openstack.org/423601
Committed: https://git.openstack.org/cgit/openstack/senlin/commit/?id=6a7ed0fbadfd6f356c2fa733bcc02f9917a627d3
Submitter: Jenkins
Branch: master

commit 6a7ed0fbadfd6f356c2fa733bcc02f9917a627d3
Author: tengqm <email address hidden>
Date: Sat Jan 21 03:48:31 2017 -0500

    Fix receiver create parameter checking

    This patch fixes the parameter checking when creating receivers. For a
    webhook type of receiver, the action cannot be CLUSTER_CREATE, for
    example.

    Closes-Bug: #1652232
    Change-Id: I3558c45644065d88208da23443b6032dc28861ea

Changed in senlin:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on senlin (master)

Change abandoned by Qiming Teng (<email address hidden>) on branch: master
Review: https://review.openstack.org/415128
Reason: This has been solved in another patch https://review.openstack.org/#/c/423601/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin 3.0.0.0b3

This issue was fixed in the openstack/senlin 3.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.