Unable to update policy

Bug #1706551 reported by lidong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
senlin-dashboard
Fix Released
Undecided
lidong

Bug Description

Reproduce:
1. Cluster/Policies page
2. Update policy selected
3. Fill name
4. update policy
=> mesg: Unable to update policy
------------------------------------
In this file https://github.com/openstack/senlin-dashboard/blob/master/senlin_dashboard/cluster/policies/forms.py
line 106: params is json
but line 109: senlin.policy_update(request, data.get('policy_id'), params)

In this file https://github.com/openstack/senlin-dashboard/blob/master/senlin_dashboard/api/senlin.py
Line 295: def policy_update(request, policy, **params):

So I got error,
I tried to change: senlin.policy_update(request, data.get('policy_id'), params) => senlin.policy_update(request, data.get('policy_id'), **params)
And policy now can update via dashboard

lidong (lidong007)
Changed in senlin-dashboard:
assignee: nobody → lidong (lidong007)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/487638

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin-dashboard (master)

Reviewed: https://review.openstack.org/487638
Committed: https://git.openstack.org/cgit/openstack/senlin-dashboard/commit/?id=3dacadf53eed2ae366fb0417357487bd6f539869
Submitter: Jenkins
Branch: master

commit 3dacadf53eed2ae366fb0417357487bd6f539869
Author: lidong <email address hidden>
Date: Thu Jul 27 09:21:49 2017 +0800

    Unable to update policy

    params is json
    changed:- senlin.policy_update(request, data.get('policy_id'), params)
    To:- senlin.policy_update(request, data.get('policy_id'), **params)

    Change-Id: Ie13dc7f487c0b5a9660c631cd53a40310e121f3e
    Closes-Bug: #1706551

Changed in senlin-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin-dashboard 0.7.0

This issue was fixed in the openstack/senlin-dashboard 0.7.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.