SST duplicates test_ when the file name starts with test_
Bug #1064851 reported by
Leo Arias
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| selenium-simple-test |
Fix Released
|
High
|
Vincent Ladeuil | ||
Bug Description
It's a common pattern to start test files with test_.
SST assumes that all the files on the directory are tests, so it adds the test_. But that's a problem when we want to follow the pattern and make it clearer that the files are tests.
So, if the test files start with test_, SST shouldn't add it.
Related branches
lp:~elopio/selenium-simple-test/fix-1064851
- Canonical ISD QA Team: Pending requested
-
Diff: 29 lines (+9/-2)1 file modifiedsrc/sst/runtests.py (+9/-2)
lp:~vila/selenium-simple-test/test-loader
- Corey Goldberg (community): Approve
- Leo Arias (community): Approve (code review)
-
Diff: 1483 lines (+470/-754)9 files modifiedsrc/sst/filters.py (+3/-3)
src/sst/loader.py (+131/-286)
src/sst/result.py (+0/-3)
src/sst/runtests.py (+10/-17)
src/sst/selftests/shared/__init__.py (+3/-0)
src/sst/tests/test_filters.py (+1/-2)
src/sst/tests/test_loader.py (+272/-413)
src/sst/tests/test_runtests.py (+50/-1)
test-loader.TODO (+0/-29)
| Changed in selenium-simple-test: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Vincent Ladeuil (vila) wrote | #1 |
| Changed in selenium-simple-test: | |
| assignee: | Leo Arias (elopio) → Vincent Ladeuil (vila) |
| status: | Fix Committed → In Progress |
| Changed in selenium-simple-test: | |
| importance: | Undecided → High |
| Changed in selenium-simple-test: | |
| status: | In Progress → Fix Committed |
| Changed in selenium-simple-test: | |
| milestone: | none → 0.2.4 |
| Changed in selenium-simple-test: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
@Leo: I'm a bit confused here, the bug is marked fix committed but the associated merge proposal is marked rejected ?