OpenStack Searchlight

[searchlight-ui] InvalidURL error

Bug #1646707 reported by Liyingjun
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Searchlight
Fix Released
Medium
Liyingjun

Bug Description

When the endpoint isn't end with slash like (http://192.168.81.139:9393), the ui fails with:

[Fri Dec 02 15:26:48.807628 2016] [wsgi:error] [pid 37:tid 140546708051712] WARNING:oslo_policy.policy:Policies ['update_rbac_policy:target_tenant'] are part of a cyclical reference.
[Fri Dec 02 15:26:50.299732 2016] [wsgi:error] [pid 41:tid 140546708051712] HTTP exception with no status/code
[Fri Dec 02 15:26:50.299753 2016] [wsgi:error] [pid 41:tid 140546708051712] Traceback (most recent call last):
[Fri Dec 02 15:26:50.299756 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/openstack_dashboard/api/rest/utils.py", line 126, in _wrapped
[Fri Dec 02 15:26:50.299759 2016] [wsgi:error] [pid 41:tid 140546708051712] data = function(self, request, *args, **kw)
[Fri Dec 02 15:26:50.299760 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/searchlight_ui/api/rest/searchlight.py", line 89, in get
[Fri Dec 02 15:26:50.299762 2016] [wsgi:error] [pid 41:tid 140546708051712] return searchlight_get('/search/plugins', request).json()
[Fri Dec 02 15:26:50.299765 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/searchlight_ui/api/rest/searchlight.py", line 178, in _searchlight_request
[Fri Dec 02 15:26:50.299767 2016] [wsgi:error] [pid 41:tid 140546708051712] params=params
[Fri Dec 02 15:26:50.299778 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/api.py", line 70, in get
[Fri Dec 02 15:26:50.299780 2016] [wsgi:error] [pid 41:tid 140546708051712] return request('get', url, params=params, **kwargs)
[Fri Dec 02 15:26:50.299782 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/api.py", line 56, in request
[Fri Dec 02 15:26:50.299784 2016] [wsgi:error] [pid 41:tid 140546708051712] return session.request(method=method, url=url, **kwargs)
[Fri Dec 02 15:26:50.299785 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/sessions.py", line 461, in request
[Fri Dec 02 15:26:50.299787 2016] [wsgi:error] [pid 41:tid 140546708051712] prep = self.prepare_request(req)
[Fri Dec 02 15:26:50.299789 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/sessions.py", line 394, in prepare_request
[Fri Dec 02 15:26:50.299791 2016] [wsgi:error] [pid 41:tid 140546708051712] hooks=merge_hooks(request.hooks, self.hooks),
[Fri Dec 02 15:26:50.299792 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/models.py", line 294, in prepare
[Fri Dec 02 15:26:50.299794 2016] [wsgi:error] [pid 41:tid 140546708051712] self.prepare_url(url, params)
[Fri Dec 02 15:26:50.299796 2016] [wsgi:error] [pid 41:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/models.py", line 348, in prepare_url
[Fri Dec 02 15:26:50.299797 2016] [wsgi:error] [pid 41:tid 140546708051712] raise InvalidURL(*e.args)
[Fri Dec 02 15:26:50.299799 2016] [wsgi:error] [pid 41:tid 140546708051712] InvalidURL: Failed to parse: 192.168.81.139:9393v1
[Fri Dec 02 15:26:50.310298 2016] [wsgi:error] [pid 38:tid 140546708051712] HTTP exception with no status/code
[Fri Dec 02 15:26:50.310317 2016] [wsgi:error] [pid 38:tid 140546708051712] Traceback (most recent call last):
[Fri Dec 02 15:26:50.310319 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/openstack_dashboard/api/rest/utils.py", line 126, in _wrapped
[Fri Dec 02 15:26:50.310332 2016] [wsgi:error] [pid 38:tid 140546708051712] data = function(self, request, *args, **kw)
[Fri Dec 02 15:26:50.310333 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/searchlight_ui/api/rest/searchlight.py", line 89, in get
[Fri Dec 02 15:26:50.310336 2016] [wsgi:error] [pid 38:tid 140546708051712] return searchlight_get('/search/plugins', request).json()
[Fri Dec 02 15:26:50.310338 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/searchlight_ui/api/rest/searchlight.py", line 178, in _searchlight_request
[Fri Dec 02 15:26:50.310340 2016] [wsgi:error] [pid 38:tid 140546708051712] params=params
[Fri Dec 02 15:26:50.310341 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/api.py", line 70, in get
[Fri Dec 02 15:26:50.310343 2016] [wsgi:error] [pid 38:tid 140546708051712] return request('get', url, params=params, **kwargs)
[Fri Dec 02 15:26:50.310345 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/api.py", line 56, in request
[Fri Dec 02 15:26:50.310347 2016] [wsgi:error] [pid 38:tid 140546708051712] return session.request(method=method, url=url, **kwargs)
[Fri Dec 02 15:26:50.310349 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/sessions.py", line 461, in request
[Fri Dec 02 15:26:50.310351 2016] [wsgi:error] [pid 38:tid 140546708051712] prep = self.prepare_request(req)
[Fri Dec 02 15:26:50.310352 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/sessions.py", line 394, in prepare_request
[Fri Dec 02 15:26:50.310362 2016] [wsgi:error] [pid 38:tid 140546708051712] hooks=merge_hooks(request.hooks, self.hooks),
[Fri Dec 02 15:26:50.310364 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/models.py", line 294, in prepare
[Fri Dec 02 15:26:50.310366 2016] [wsgi:error] [pid 38:tid 140546708051712] self.prepare_url(url, params)
[Fri Dec 02 15:26:50.310368 2016] [wsgi:error] [pid 38:tid 140546708051712] File "/var/lib/kolla/venv/lib/python2.7/site-packages/requests/models.py", line 348, in prepare_url
[Fri Dec 02 15:26:50.310369 2016] [wsgi:error] [pid 38:tid 140546708051712] raise InvalidURL(*e.args)
[Fri Dec 02 15:26:50.310371 2016] [wsgi:error] [pid 38:tid 140546708051712] InvalidURL: Failed to parse: 192.168.81.139:9393v1

Liyingjun (liyingjun)
Changed in searchlight:
assignee: nobody → Liyingjun (liyingjun)
importance: Undecided → Medium
Revision history for this message
Liyingjun (liyingjun) wrote :

https://review.openstack.org/405978

Changed in searchlight:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/405978

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight-ui (master)

Reviewed: https://review.openstack.org/405978
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=b49a723efe804f96286f03aa22aba7c2299a32a0
Submitter: Jenkins
Branch: master

commit b49a723efe804f96286f03aa22aba7c2299a32a0
Author: liyingjun <email address hidden>
Date: Fri Dec 2 16:01:34 2016 +0800

    Use urlparse.urljoin to join searchlight url

    When the searchlight endpoint isn't end with slash, the url generated
    will be wrong.

    Change-Id: I3e57b9dda9ebe63afd0381d0f9bf2831c4464059
    Closes-bug: #1646707

Changed in searchlight:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight-ui (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/409104

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight-ui (stable/newton)

Reviewed: https://review.openstack.org/409104
Committed: https://git.openstack.org/cgit/openstack/searchlight-ui/commit/?id=d94a65507b59336504bc68fbefe6b9f610a7cba2
Submitter: Jenkins
Branch: stable/newton

commit d94a65507b59336504bc68fbefe6b9f610a7cba2
Author: liyingjun <email address hidden>
Date: Fri Dec 2 16:01:34 2016 +0800

    Use urlparse.urljoin to join searchlight url

    When the searchlight endpoint isn't end with slash, the url generated
    will be wrong.

    Change-Id: I3e57b9dda9ebe63afd0381d0f9bf2831c4464059
    Closes-bug: #1646707
    (cherry picked from commit b49a723efe804f96286f03aa22aba7c2299a32a0)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/searchlight-ui 2.0.0.0b2

This issue was fixed in the openstack/searchlight-ui 2.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/searchlight-ui 1.0.1

This issue was fixed in the openstack/searchlight-ui 1.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/439539

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on searchlight-ui (stable/mitaka)

Change abandoned by Joshua Hesketh (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/439539
Reason: This branch (stable/mitaka) is at End Of Life

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.