Generated version numbers are returned as strings

Bug #1550494 reported by Steve McLellan
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Searchlight
Fix Released
Low
Russell Tweed

Bug Description

The code in IndexBase:get_version returns strings for versions:

   return '%s%s' % (str(updated_epoch)[-9:], truncate_timestamp)

It looks like Elasticsearch converts them (at least in 1.x) so it's not causing any actual problems but would be good to tidy it up.

Changed in searchlight:
assignee: nobody → Varun Kavalipurapu (varun-vr850)
Changed in searchlight:
assignee: Varun Kavalipurapu (varun-vr850) → nobody
Changed in searchlight:
assignee: nobody → Ruchi Parmar (ruchiparmar143)
Neha (neha-m-pande)
Changed in searchlight:
assignee: Ruchi Parmar (ruchiparmar143) → Neha (neha-m-pande)
Changed in searchlight:
assignee: Neha (neha-m-pande) → Annapoornima Koppad (annakoppad)
Rahul (rahurama)
Changed in searchlight:
assignee: Annapoornima Koppad (annakoppad) → Rahul (rahurama)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight (master)

Fix proposed to branch: master
Review: https://review.openstack.org/339404

Changed in searchlight:
status: New → In Progress
Revision history for this message
Rahul (rahurama) wrote :

Ironically the build tests are failing, mainly because the test cases are expecting a string and not an int.

Changed in searchlight:
assignee: Rahul (rahurama) → Marianne Linhares Monteiro (mariannelinharesm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/387048

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on searchlight (master)

Change abandoned by Marianne Linhares Monteiro (<email address hidden>) on branch: master
Review: https://review.openstack.org/387048

Changed in searchlight:
assignee: Marianne Linhares Monteiro (mariannelinharesm) → nobody
Changed in searchlight:
assignee: nobody → Russell Tweed (russell-tweed)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight (master)

Fix proposed to branch: master
Review: https://review.openstack.org/550820

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on searchlight (master)

Change abandoned by Trinh Nguyen (<email address hidden>) on branch: master
Review: https://review.openstack.org/339404
Reason: Abandon in favor of https://review.openstack.org/#/c/550820/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight (master)

Reviewed: https://review.openstack.org/550820
Committed: https://git.openstack.org/cgit/openstack/searchlight/commit/?id=6a65cdad2abb2164d9a28907b4f189829bae5cb4
Submitter: Zuul
Branch: master

commit 6a65cdad2abb2164d9a28907b4f189829bae5cb4
Author: Russell Tweed <email address hidden>
Date: Thu Mar 8 12:51:53 2018 +0000

    Converted String timestamp to Int

    Continuing work on earlier abandoned patch

    Change-Id: I6931ecbc5f895887add97701d0c24ff79923cfdf
    Closes-Bug: 1550494

Changed in searchlight:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/searchlight 6.0.0.0b1

This issue was fixed in the openstack/searchlight 6.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.