Property mapping for Metadef properties regressed to "name" from "property"

Bug #1492579 reported by Lakshmi N Sampath
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Searchlight
Fix Released
High
Lakshmi N Sampath

Bug Description

Property mapping for Metadef properties regressed to "name" from "property".

Glance Metadef plugin at some point in previous commits had a regression on the mapping for property name.
Previous it was "property" and now its changed to "name" which causes the listener to fail on property updates with objects and namespaces.

To recreate the bug. Try updating a property on a namespace and check if the name of the property in the elastic search document which will not have the updated name.

Revision history for this message
Lakshmi N Sampath (lakshmi-sampath) wrote :

We could either change property structure to the previous like

                'properties': [{
                    'default': 'value1',
                    'description': None,
                    'property': 'property1',
                    'type': 'string',
                    'title': 'something title'
                }]

or keep it the same and change the listener to process this structure.

 'properties': [{
                    'default': 'value1',
                    'description': None,
                    'name': 'property1',
                    'type': 'string',
                    'title': 'something title'
                }]

I have tested the fix with with both structures to work. The old way of calling property name as "property" was done to make it more specific for properties but I could change it either way. Lets discuss it and i can provide the patch.

Changed in searchlight:
milestone: none → liberty-rc1
assignee: nobody → Lakshmi N Sampath (lakshmi-sampath)
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to searchlight (master)

Fix proposed to branch: master
Review: https://review.openstack.org/228531

Changed in searchlight:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to searchlight (master)

Reviewed: https://review.openstack.org/228531
Committed: https://git.openstack.org/cgit/openstack/searchlight/commit/?id=36ceaaf23fe28431bf4a5ec591e70f3ef94192ef
Submitter: Jenkins
Branch: master

commit 36ceaaf23fe28431bf4a5ec591e70f3ef94192ef
Author: Lakshmi N Sampath <email address hidden>
Date: Mon Sep 28 21:55:46 2015 +0530

    Fix for Property mapping for Metadef properties fails

    Property mapping for Metadef properties regressed to
    "name" from "property".

    Glance Metadef plugin at some point in previous commits
    had a regression on the mapping for property name.
    Previous it was "property" and now its changed to "name" which
    causes the listener to fail on property updates with
    objects and namespaces.

    To recreate the bug. Try updating a property on a namespace
    and check if the name of the property in the elastic search
    document which will not have the updated name.

    Change-Id: I1c4e8ec8f1b9648668c9957c88d913bd76834e9e
    Closes-Bug: #1492579

Changed in searchlight:
status: In Progress → Fix Committed
Changed in searchlight:
status: Fix Committed → Fix Released
Changed in searchlight:
milestone: liberty-rc1 → 0.1.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.