investigate if repub_state=3 (foldout) should go through modify-xml

[danh]

Right now, when you set the repub_state of an item to 3 (to send something to a foldout machine), the code does a direct db write.

This happens in petabox/www/datanode/RePublisher/RePublisher-gotoFoldout.php

We've been trying to move at least some of our code away from direct db writes, towards going through an interface such as modify xml that will both write the db as well as write the *meta.xml and leave a trace in the log as to what has happened.

We should at least investigate doing that here as well.

(I don't know if there are some reasons for which this is not practical, for example, if we are worried that this will tie up books if the jobs greenrow too long. So if there are such reasons we hopefully can find them and deal with them.)

[Hank Bromley (hank-archive)]

I believe the code in mark-book-busy.php will work as-is for modifying repub_state and scanner, as those elements are already on the list of those allowed to be modified through that route.

You can adapt the code now in Scriblio.inc for calling mark-book-busy.php to be used in RePublisher-gotoFoldout.php, too. (Or put the common part of the code someplace where it can be shared.)

We probably, though, ought to change the name of the mark-book-busy.php script to something more general, so it makes sense in both calling contexts. Maybe remote-modxml.php or some such?