Ctrl+f should focus the find text box when it is visible

Bug #1592699 reported by Zisu Andrei
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Medium
Jeremy Wootten

Bug Description

In most editors (atom, intellij, sublime), when you press ctrl+f:
  If the find toolbar is not shown, it will be shown
  If the find toolbar is shown but not focused, if will be focued

The find toolbar is hidden by pressing esc (just like Scratch does).

Related branches

Revision history for this message
Zisu Andrei (matzipan) wrote :

Further, if a bit of text is selected when pressing ctrl+f, then this should be the value of the search query.

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Is the bug the fact that if the find box is shown, Ctrl-f hides it instead of focussing? The other issues mentioned seem to work already (if the find box is not showing when Ctrl-f is pressed).

Revision history for this message
Zisu Andrei (matzipan) wrote :

Sorry, bad reporting :( the issue is in the title. The rest was just me explaining that the current behaviour is correct.

Revision history for this message
Zisu Andrei (matzipan) wrote :

More concise and less ambiguous:

After opening the search bar once, pressing ctrl+f again closes the search bar instead of focusing the search box.

summary: - Ctrl+f should focus the find text box
+ Ctrl+f should focus the find text box when it is visible
Changed in scratch:
status: New → Confirmed
importance: Undecided → Medium
Changed in scratch:
status: Confirmed → In Progress
assignee: nobody → Jeremy Wootten (jeremywootten)
Zisu Andrei (matzipan)
Changed in scratch:
status: In Progress → Fix Committed
Changed in scratch:
milestone: none → loki-rc1
Cody Garver (codygarver)
Changed in scratch:
milestone: loki-rc1 → loki-alpha1
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.