Ugly margins in dialogs since Gtk+-3.14

Bug #1411808 reported by Marcus Wichelmann on 2015-01-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Eidete
Undecided
Marcus Wichelmann
Maya
Fix Released
Low
Corentin Noël
Noise
Fix Released
Undecided
Marcus Wichelmann
Photos
Fix Released
Undecided
Fabio Zaramella
Scratch
Fix Released
Low
Marcus Wichelmann

Bug Description

Since the update to Gtk+-3.14 the margins of some dialogs are too small. That indication-error is caused by the "Object (use_header_bar: 1);"-workaround to hide the close-buttons.

To fix that remove theese lines:

Object (use_header_bar: 1);
(this.get_header_bar () as Gtk.HeaderBar).show_close_button = false;
this.get_header_bar ().get_style_context ().remove_class ("header-bar");

And replace them with:

this.deletable = false;

(http://valadoc.org/#!api=gtk+-3.0/Gtk.Window.deletable)

Related branches

Marcus Wichelmann (l-admin-3) wrote :
description: updated
Daniel Fore (danrabbit) on 2015-01-16
Changed in noise:
milestone: none → freya-rc1
Changed in scratch:
status: New → In Progress
assignee: nobody → Marcus Wichelmann (l-admin-3)
description: updated
Changed in scratch:
status: In Progress → Fix Committed
Changed in noise:
status: New → In Progress
assignee: nobody → Marcus Wichelmann (l-admin-3)
Corentin Noël (tintou) on 2015-01-16
Changed in maya:
assignee: nobody → Corentin Noël (tintou)
Changed in eidete:
status: New → In Progress
assignee: nobody → Marcus Wichelmann (l-admin-3)
Corentin Noël (tintou) on 2015-01-17
Changed in maya:
status: New → Fix Committed
importance: Undecided → Low
milestone: none → freya-beta2
Daniel Fore (danrabbit) on 2015-01-17
Changed in scratch:
milestone: none → freya-beta2
Daniel Fore (danrabbit) on 2015-01-17
Changed in eidete:
status: In Progress → Fix Committed
Changed in noise:
status: In Progress → Fix Committed
milestone: freya-rc1 → freya-beta2
Changed in pantheon-photos:
status: New → In Progress
assignee: nobody → Fabio Zaramella (fabiozaramella)
Changed in pantheon-photos:
status: In Progress → Fix Committed
Daniel Fore (danrabbit) on 2015-02-08
Changed in pantheon-photos:
milestone: none → freya-beta2
Daniel Fore (danrabbit) on 2015-02-10
Changed in maya:
status: Fix Committed → Fix Released
Changed in noise:
status: Fix Committed → Fix Released
Changed in pantheon-photos:
status: Fix Committed → Fix Released
Changed in scratch:
status: Fix Committed → Fix Released
Cody Garver (codygarver) on 2015-04-11
Changed in scratch:
milestone: freya-beta2 → 2.1
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers