Use "edit-find-replace-symbolic" in search and replace

[swizzle]

The second find bar text fild which contains the place holder replace with has a find icon in the text field.
This monochrome find icon should be replaced by the colored search replace icon (but obviously also by a monochrome one).

It makes more sense to have search replace icon in the text field itself.

[Cody Garver (codygarver)]

Design team, what icon is it supposed to be?

[Danielle Foré (danrabbit)]

edit-find-replace-symbolic

[Cody Garver (codygarver)]

Fixing this bug would also fix the deprecated icon:

src/Widgets/SearchManager.vala

replace_tool_button = new Gtk.ToolButton.from_stock (Gtk.Stock.FIND_AND_REPLACE);

[Danielle Foré (danrabbit)]

Cody, I think that's probably a separate report.

I don't think using the primary entry icon for the replace action makes as much sense as OP thinks it does. We usually put actions in the secondary position and options or descriptions in the primary position. In this case, "clear" is already in the secondary position. So I think the action icon for replace would stay right where it is.

[Danielle Foré (danrabbit)]

That, and we usually don't group bug reports so...

[Robert Roth (evfool)]

The only problem I see with this is that there is no symbolic variant of 'edit-find-replace' in either Adwaita or Elementary Icons, and using the 'edit-find-replace' icon looks awful. Daniel, can we get a symbolic find and replace in the elementary icon theme?