spell-check plugin fails to build against gtkspell-3.0.0 release

Bug #1087704 reported by Pim Vullers
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Undecided
Unassigned

Bug Description

When trying to build scratch and the spell-check plugin I run into errors. First I had to update the following line:

pkg_check_modules (SPELL REQUIRED "gtkspell-3.0")

to:

pkg_check_modules (SPELL REQUIRED "gtkspell3-3.0")

for pkg-config to find the 3.0.0 release of gtkspell. With this fix the configure succeeds and build starts, but fails with:

/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build/plugins/spell-check/spell-check.c: In function 'scratch_plugins_spell_check_on_new_source_view':
/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build/plugins/spell-check/spell-check.c:183:3: error: unknown type name 'GtkSpell'
/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build/plugins/spell-check/spell-check.c:184:3: error: unknown type name 'GtkSpell'
/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build/plugins/spell-check/spell-check.c:186:10: warning: assignment makes pointer from integer without a cast [enabled by default]
make[2]: *** [plugins/spell-check/CMakeFiles/spellcheck.dir/spell-check.c.o] Error 1
make[2]: Leaving directory `/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build'
make[1]: *** [plugins/spell-check/CMakeFiles/spellcheck.dir/all] Error 2
make[1]: Leaving directory `/tmp/portage/app-editors/scratch-9999/work/scratch-9999_build'
make: *** [all] Error 2

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

what is your libgtkspell version? It works on Luna.

Changed in scratch:
status: New → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Scratch because there has been no activity for 60 days.]

Changed in scratch:
status: Incomplete → Expired
Revision history for this message
Pim Vullers (pimvullers) wrote :

Sorry, I must have missed your response, As mentioned at the beginning, I'm using gtkspell version 3.0.0.

Changed in scratch:
status: Expired → Incomplete
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Scratch because there has been no activity for 60 days.]

Changed in scratch:
status: Incomplete → Expired
Pim Vullers (pimvullers)
Changed in scratch:
status: Expired → New
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I dropped gtkspell plugin. I can't see the point why a text editor should have spell checking, also, vala binding seems to not work properly.

Changed in scratch:
status: New → Invalid
Revision history for this message
Kazade (kazade) wrote :

I've re-opened this because it's a problem when compiling scratch on Fedora 19. I have exactly the same issue, pkg-config lists gtkspell3 as "gtkspell3-3.0" and if I make that change the CMakeLists.txt file I end up with the following:

/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:63:2: error: unknown type name ‘GtkSpell’
  GtkSpell* spell;
  ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c: In function ‘___lambda3_’:
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:136:3: error: unknown type name ‘GtkSpell’
   GtkSpell* _tmp2_;
   ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c: In function ‘__lambda2_’:
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:154:2: error: unknown type name ‘GtkSpell’
  GtkSpell* _tmp4_ = NULL;
  ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:155:2: error: unknown type name ‘GtkSpell’
  GtkSpell* _tmp5_;
  ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:164:9: warning: assignment makes pointer from integer without a cast [enabled by default]
  _tmp4_ = gtkspell_get_from_text_view ((GtkTextView*) _tmp3_);
         ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:179:4: error: unknown type name ‘GtkSpell’
    GtkSpell* _tmp9_;
    ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:180:4: error: unknown type name ‘GtkSpell’
    GtkSpell* _tmp10_;
    ^
/home/kazade/Elementary/scratch/build/plugins/spell/spell.c:183:11: warning: assignment makes pointer from integer without a cast [enabled by default]
    _tmp9_ = gtkspell_new_attach ((GtkTextView*) _tmp7_, _tmp8_, &_inner_error_);
           ^
make[2]: *** [plugins/spell/CMakeFiles/spell.dir/spell.c.o] Error 1
make[1]: *** [plugins/spell/CMakeFiles/spell.dir/all] Error 2
make: *** [all] Error 2

Changed in scratch:
status: Invalid → Confirmed
Revision history for this message
Chris Johns (ter0) wrote :

Same issue trying to compile on Saucy

Changed in scratch:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.