Filename displays as URI format in tabs and windows

Bug #1046534 reported by Darcy Luís Neves Brás da Silva
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Scratch
Fix Released
Medium
Mario Guerriero

Bug Description

A file of the name "new file" appears with incorrect name on the tab and window. The result is something like "new%20file" .

scratch version
version 1.1.1

Related branches

summary: - Bad Escape Sequence when displaying name of the file in Tabs
+ Filename displays as URI format in tabs and windows
description: updated
Changed in scratch:
assignee: nobody → Darcy Luís Neves Brás da Silva (darcy-develin)
Revision history for this message
Darcy Luís Neves Brás da Silva (darcy-develin) wrote :

I have fixed it now i need some help fighting bzr , none the less i attach a diff file along with this comment and a copy of my commit message (on my branch).

https://code.launchpad.net/~darcy-develin/+junk/scratch-patch-branch

cmsg:
Fixes bug #1046534, filename now displays properly both in tabs and windows.
 Apperantly filename is still uri encoded, maybe someone needs to
 see a better alternative with some regex that decodes it. Because
 'creating' a file just for this purpose is lookin inefficient
 none the less for now is fixed.

Revision history for this message
Darcy Luís Neves Brás da Silva (darcy-develin) wrote :

Here i leave another diff file that adds a missing unref.

PS: this patch should only be applied after the previous one.?field.comment=Here i leave another diff file that adds a missing unref.

PS: this patch should only be applied after the previous one.

Revision history for this message
Darcy Luís Neves Brás da Silva (darcy-develin) wrote :

I finally managed to get bzr karate working with the help of codygarver (many thanks) and so i did a proper "ready" for merge branch

https://code.launchpad.net/~darcy-develin/scratch/fix-1046534/+merge/123164

Cody Garver (codygarver)
Changed in scratch:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → 1.2
Changed in scratch:
status: Fix Committed → In Progress
Changed in scratch:
status: In Progress → Fix Committed
Revision history for this message
Darcy Luís Neves Brás da Silva (darcy-develin) wrote :

mefrio, I'm not sure this is indeed fixed since the fix was reverted later on...

Changed in scratch:
status: Fix Committed → Confirmed
Changed in scratch:
status: Confirmed → Fix Committed
Changed in scratch:
status: Fix Committed → Confirmed
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I just made a different fix and it works fine now.

Changed in scratch:
assignee: Darcy Luís Neves Brás da Silva (darcy-develin) → Mario Guerriero (mefrio-g)
status: Confirmed → Fix Committed
Revision history for this message
Darcy Luís Neves Brás da Silva (darcy-develin) wrote :

Ok, good. thanks for the notice

Changed in scratch:
status: Fix Committed → Fix Released
Changed in scratch:
status: Fix Released → Fix Committed
Cody Garver (codygarver)
Changed in scratch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.