chmod is broken and insecure
Bug #1021725 reported by
Sergey "Shnatsel" Davidoff
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Scratch |
Fix Released
|
Critical
|
Mario Guerriero | ||
Bug Description
I appreciate attempting to make some files executable on initial save, but the way it's currently implemented is really ugly. You're using a wrapper to system() syscall instead of using chmod() UNIX function. Besides being broken (here's what I get in console on saving:
"chmod: missing operand after `+x'
Try `chmod --help' for more information." ) it presents a potential security vulnerability.
Please use chmod() unix function instead.
| Changed in scratch: | |
| milestone: | none → luna-beta1 |
| summary: |
- chmod is broken and ugly + chmod is broken and insecure |
Revision history for this message
| Mario Guerriero (mefrio-g) wrote | #1 |
| Changed in scratch: | |
| status: | New → Confirmed |
Revision history for this message
| xapantu (xapantu) wrote | #2 |
Revision history for this message
| Mario Guerriero (mefrio-g) wrote | #3 |
| Changed in scratch: | |
| assignee: | nobody → Mario Guerriero (mefrio-g) |
| security vulnerability: | yes → no |
| visibility: | private → public |
| Changed in scratch: | |
| status: | Confirmed → Fix Committed |
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | #4 |
| Changed in scratch: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
yeah it is a very very ugly implementation