References to gradients in <style> are not considered as such; the gradients are removed
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Scour |
High
|
Unassigned | ||
Bug Description
The file fulltests/
-- To reproduce --
Program version: trunk revision 180
Command line: ./scour.py --shorten-ids --enable-
| Changed in scour: | |
| importance: | Undecided → High |
| summary: |
- Bad render: fulltests/scantailor.svg + References to gradients in <style> are not considered as such; the + gradients are removed |
Debug information added by this patch (not a solution for the bug!) makes the problem more obvious:
A CDATA node may be surrounded by Text nodes if CDATA is surrounded by whitespace, but findReferencedE
| Changed in scour: | |
| status: | New → Triaged |
| Changed in scour: | |
| assignee: | nobody → Cynthia Gauthier (louis-simard) |
| status: | Triaged → In Progress |
This patch has two facets:
1. Allow findReferencedE
2. Allow renameID (for shortenIDs) to replace a stylesheet properly.
Unit tests have been written. The file now renders correctly, and the unit tests both pass.
This fix is in the trunk, revision 184.
| Changed in scour: | |
| status: | In Progress → Fix Committed |
| Changed in scour: | |
| status: | Fix Committed → Fix Released |
Even with the default command-line options, the fill:url(#idNUMBER) references in <style> aren't being considered as references and the gradients are getting removed from <defs>.