Nearby Scope wrong data

[Krzysztof Tataradziński]

Hello,

since yesterday OTA, NearBy sometimes doesn't load data as it should. Please see video for details:

https://drive.google.com/file/d/1eT0c4KVlZVJvDdmDKzOal6EhDAmBc66YIg/view

in example (1:18) there is a text 'Bankomaty (ATM)...', but showing weather.
1:20 - "Gry pomagające się wyładować (Games to let off some steam)" - below that phase we can see hairdresser or beauty place.
2:09 - again "Bankomaty (ATM)...", but we see bars.
Choosing "Nudzę się (bored)" don't do nothing - loads the same data as general "Jak się czujesz (how do you feel)".

I installed also Places scope and added it to NearBy.
My suggestion (I don't know where that should be placed): there should be more results than 4 (if we choose 'see all', we see...one more), like in Yelp. And pictures should be smaller.
Also in Places scope there should be option to rate place.

[Pat McGowan (pat-mcgowan)]

The key is the installation of the Places scope which seems to cause the other scopes to return the wrong results.

[Kyle Nitzsche (knitzsche)]

on:

phablet@ubuntu-phablet:~$ system-image-cli -i
current build number: 184
device name: krillin
channel: ubuntu-touch/rc-proposed/bq-aquaris.en
last update: 2015-11-20 14:16:03
version version: 184

I see a golang panic on poi scope. see attached

After installing Places, in On the Move dept, I see Places Nearby at the top (even above nominatim). It should be at the bottom so something seems amiss.

[Kyle Nitzsche (knitzsche)]

Why does this bug also affect Today?

[Kyle Nitzsche (knitzsche)]

ok with fresh OTA8 install on krillin, and only after installing Places scope, I can reproduce.

* "I'm Stressed" for example has issues: Nearby Places is at the top, but it should be last since it is aggregated by keyword that comes last in the order.
* And Fashion from Yelp category includes weather results, and lower categories also contain the wrong result types. attaching screenshot.

NOTE: disabling Places in settings fixes Nearby.

[Kyle Nitzsche (knitzsche)]

I just launched Today and I do not see Places in settings, so I don't think this bug affects Today and will remove that.

[Kyle Nitzsche (knitzsche)]

I think I see the problem.

This is the first case I think where we have had a single scope (in this case the Places scope) being aggregated multiple times into a single aggregator. If I modify nearby to only aggregate one of the keywords Places advertises, all seems well. Add a second keyword though and there are issues. So I will continue to ferret this out.

Cheers

[Kyle Nitzsche (knitzsche)]

And I have a fix. will make an MR, test, etc.

[Kyle Nitzsche (knitzsche)]

please see https://code.launchpad.net/~knitzsche/scope-aggregator/ota8-nearby-places-bug-1518346/+merge/278227

[Kyle Nitzsche (knitzsche)]

The problem and fix relates to the specific case where an agg scope includes one child scope multiple times using basic "keyword" declaration:
"order": [
    {
        "keyword":
         {
             "keyword": "nearby.thirsty",
              "department": "dept-thirsty"
         }
    },
...
]

The following worked previously and still works (from News scope):
"order": {
    {
        "category":
         {
            "id": "headlines",
            "department": "dept-headlines",
            "_title": "",
...
            "scopes":
            [
             ],
             "keywords":
             [
                 {
                    "id": "news.headlines",
                    "local_id": "headlines_kw_cat-1"
                 }
             ]
        }
     },
...
]

[Kyle Nitzsche (knitzsche)]

There are two agg scopes I know of that need rebasing on scope-agg 4.1, QA testing, and release because they use simple keyword aggregation as described in comment #9:

* Today (due to "recent" keyword aggregation)
* NearBy (due to multiple

I will attach Today (aka dashboard) 4.1.0 and NearBy 4.1.0 for QA and release.

I am therefore assigning this bug Penk for QA and release.

[Kyle Nitzsche (knitzsche)]

Currently, Today scope is not affected by the bug because no single child scope is agged multiple times through different keywords.

However, because Today does perform simple keyword agg, we should rebase on 4.1 to protect against modified json declarations in future versions in a way that would invoke the bug.

So I do not think we need to release Today scope just for this.

[Elsa Wang (elsawang)]

@Ethan, could you please help to verify this? thanks!

[Ethan Chang (ethan.chang)]

Verified with dashboard 4.1.0 and nearby 4.1.0 packages.

[Penk Chen (penk)]

Click package uploaded to store. Mark as fix released.

[Kyle Nitzsche (knitzsche)]

Mark as invalid on Today scope since it is not affected in its current configuration.