move child_scopes() out of factory method scope::search()

Bug #1479901 reported by Kyle Nitzsche
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
scope-aggregator
Fix Released
High
Kyle Nitzsche

Bug Description

Factory methods should return as quickly as possible. Currently child_scopes() is called while being passed to the Query constructor inside scope::search() (a factory method). This creates the potential for timeout exceptions.

Therefore, the child_scopes() should be moved, perhaps into the Query::run() method, since that has no time constraints and the Query has a pointer to the Scope and so can run the method.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

fixed with release 1.5.22

Changed in scope-aggregator:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.