SCIPIO_TRUST_URL raises AttributeError

Bug #517538 reported by Sergei Lebedev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Scipio
Won't Fix
Undecided
Unassigned

Bug Description

Despite the description in scipio/settings.py SCIPIO_TRUST_URL raises AttributeError when it's not defined in project's settings. A tiny patch to fix this is attached.

description: updated
Revision history for this message
Ivan Sagalaev (isagalaev) wrote :

The thing is, it's kind of "by design" :-). General idea is that writing "get(settings, SETTING)" everywhere is not beautiful. So Scipio expects that a user should import all its default settings into the main settings file ("from scipio.settings import *") and then alter some of them if needed. Though currently it doesn't say this anywhere...

Are you happy with this approach?

Revision history for this message
Sergei Lebedev (superbobry) wrote :

Updated patch: another bug spotted, the check for HttpResponse in views.scipio.complete will never succeed.

Revision history for this message
Sergei Lebedev (superbobry) wrote :

Oh, i saw some apps, doing the same thing by introducing the local_settings module, which did some dirty monkeypatching on django.conf.settings, adding default values, when needed. Anyway, thanks for the reply and for scipio. ;)

Revision history for this message
Ivan Sagalaev (isagalaev) wrote :

I saw these too, didn't like 'em :-). What I'm doing here is the same thing that Django recommends for user urlconfs that all start with "from django.conf.urls.defaults import *".

Changed in scipio:
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.