SchoolTool 1.0.4 breaks CanDo trunk

[Douglas Cerna]

I just confirmed what fsufitch reported in IRC (http://schooltool.pov.lt/irclogs/latest.log.html#t2010-01-05T01:12:46).

After checking out CanDo's trunk and running "make" I get:

--------- %< ----------
bin/make-schooltool-instance instance instance_type=cando.cando2007
Selected and implied templates:
  schooltool#schooltool_deploy (Paste) deployment of a SchoolTool application

Variables:
  egg: instance
  instance_type: cando.cando2007
  package: instance
  project: instance
Traceback (most recent call last):
  File "bin/make-schooltool-instance", line 149, in <module>
    schooltool.paste.instance.make_schooltool_instance()
  File "/home/elbixio/Desktop/cando/eggs/schooltool-1.0.4.1-py2.5.egg/schooltool/paste/instance.py", line 30, in make_schooltool_instance
    return runner.run(args)
  File "/home/elbixio/Desktop/cando/eggs/PasteScript-1.7.3-py2.5.egg/paste/script/command.py", line 218, in run
    result = self.command()
  File "/home/elbixio/Desktop/cando/eggs/PasteScript-1.7.3-py2.5.egg/paste/script/create_distro.py", line 125, in command
    vars = template.check_vars(vars, self)
  File "/home/elbixio/Desktop/cando/eggs/schooltool-1.0.4.1-py2.5.egg/schooltool/paste/templates.py", line 43, in check_vars
    vars['instance_package'] = dict(available_types)[vars['instance_type']]
KeyError: 'cando.cando2007'
make[1]: *** [make-instance] Error 1
make[1]: se sale del directorio `/home/elbixio/Desktop/cando'
make: *** [build] Error 2
--------- %< ----------

If I change the schooltool version to 1.0.3 in my buildout.cfg the instance is created. I also wonder why the pov-cando-buildout didn't catch it.

[Gediminas Paulauskas (menesis)]

One change that was merged with bugfixes changed behaviour of bin/make-schooltool-instance. It would work if you specified "instance_type=cando2007" in Makefile.

I have reverted this change and released schooltool-1.0.4.2 . Run `bin/buildout -n` it will be picked up and will work as before.