weekly view bug section events

Bug #285514 reported by Daniel Höger on 2008-10-18
24
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool
Critical
Justas Sadzevičius

Bug Description

If you have:
- section events scheduled over a term and a timetable
- term begin date day is not the week begin day, for example: Wednesday, 01.10.2008

you have at the weekly calendar view of the first week with section events (29.09-05.10.2008) a view bug:
for example: section events from Wednesday,01.10.2008 are displayed at Monday,29.09.2008 !

I edited in the sourcefolder the file "./app/browser/cal.py" with function "getCurrentWeekTimetableEvents"

It seems to work.

Sourcefile as attachment.

Daniel Höger (hoegerd17) wrote :
Ignas Mikalajūnas (ignas) wrote :

I am looking at it, though the file is from the older version of schooltool, and there are no tests so I could not really understand how and what is being fixed. Will write a test for the described problem and try seeing if I can reproduce it, and whether the patch helps.

Changed in schooltool:
assignee: nobody → ignas
importance: Undecided → Medium
description: updated
description: updated
Daniel Höger (hoegerd17) wrote :

I edited the Sourcefile to handle the described weekly view problem.

Changed in schooltool:
assignee: Ignas Mikalajūnas (ignas) → Justas Sadzevičius (justas-pov)
importance: Medium → Critical
status: New → In Progress
Changed in schooltool:
status: In Progress → Fix Committed

Daniel, thanks for the contribution.

getCurrentWeekTimetableEvents became obsolete in newer SchoolTool versions, so I could not test your solution thoroughly.

All in all, I consider this bug resolved, but will keep my eye open in this area.

Changed in schooltool:
milestone: none → 2009.4.14
Changed in schooltool:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments