"Enter" in gradebook should not submit form

[David Burke]

Entering grades looks and functions much like a spreadsheet. In a typical spreadsheet such as Excel the user expects enter to go to the box below the current one. Schooltool does this but then also submits the form and resets the cursor position after the post. While this is typical of html forms I believe an exception should be made here to make it more intuitive. Most users automatically hit enter expecting without expecting the form to actually save. Another solution may be to have the form save but keep the cursor in the expected location (one cell below the current)

[Tom Hoffman (tom-hoffman)]

I agree -- return should move the cursor down. Saving should be pressing the save button. Perhaps we could make Ctrl-S save as well?

[Gediminas Paulauskas (menesis)]

Please push your branch to lp:~dmbst32/schooltool.gradebook/schooltool.gradebook_fix_enter and then request merge to the correct project. And mark Fix committed

[David Burke (bufke)]

Opps. Ok it's now proposed for schooltool.gradebook

[Gediminas Paulauskas (menesis)]

Justas has committed a fix so that enter would go down unless it was the last row, when it saves.

I have added a shortcut (Alt-S) to save.

Testing this, I noticed that after the page loads, "the first cell" is focused. But the first cell was selected incorrectly, not taking sorting of students or filtered activities into account. Even if it was, the chance that it was the cell you wanted to change, is as likely as any other cell. But if the cell is focused, there is a danger that accidental input can overwrite previous data.

So I changed overview to not focus anything on page load.