Exception deploying a report sheet when no templates exist

[ronny]

Go to a term, click "Deploy Report Sheet". There are no templates in the dropdown. Click "Deploy", and this error appears:

Exception

  KeyError: 'reportWorksheet'

Traceback

  File "/usr/lib/python2.6/dist-packages/zope/publisher/publish.py", line 134, in publish
  result = publication.callObject(request, obj)
File "/usr/lib/python2.6/dist-packages/zope/app/publication/zopepublication.py", line 205, in callObject
  return mapply(ob, request.getPositionalArguments(), request)
File "/usr/lib/python2.6/dist-packages/zope/publisher/publish.py", line 109, in mapply
  return debug_call(obj, args)
Extra information: <zope.browserpage.simpleviewclass.SimpleViewClass from /usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/deploy_report_worksheet.pt object at 0xcb92dcc>
File "/usr/lib/python2.6/dist-packages/zope/publisher/publish.py", line 115, in debug_call
  return obj(*args)
File "/usr/lib/python2.6/dist-packages/zope/browserpage/simpleviewclass.py", line 44, in __call__
  return self.index(*args, **kw)
File "/usr/lib/python2.6/dist-packages/zope/browserpage/viewpagetemplatefile.py", line 83, in __call__
  return self.im_func(im_self, *args, **kw)
File "/usr/lib/python2.6/dist-packages/zope/browserpage/viewpagetemplatefile.py", line 51, in __call__
  sourceAnnotations=getattr(debug_flags, 'sourceAnnotations', 0),
File "/usr/lib/python2.6/dist-packages/zope/pagetemplate/pagetemplate.py", line 115, in pt_render
  strictinsert=0, sourceAnnotations=sourceAnnotations)()
Template "/usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/deploy_report_worksheet.pt"
File "/usr/lib/python2.6/dist-packages/zope/tal/talinterpreter.py", line 271, in __call__
  self.interpret(self.program)
File "/usr/lib/python2.6/dist-packages/zope/tal/talinterpreter.py", line 343, in interpret
  handlers[opcode](self, args)
File "/usr/lib/python2.6/dist-packages/zope/tal/talinterpreter.py", line 583, in do_setLocal_tal
  self.engine.setLocal(name, self.engine.evaluateValue(expr))
File "/usr/lib/python2.6/dist-packages/zope/tales/tales.py", line 696, in evaluate
  return expression(self)
Template "/usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/deploy_report_worksheet.pt", line 1, column 0
  Expression: <PathExpr standard:u'view/update'>
File "/usr/lib/python2.6/dist-packages/zope/tales/expressions.py", line 217, in __call__
  return self._eval(econtext)
File "/usr/lib/python2.6/dist-packages/zope/tales/expressions.py", line 211, in _eval
  return ob()
File "/usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/report_card.py", line 324, in update
  self.deploy()
File "/usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/report_card.py", line 365, in deploy
  self.deployTerm(self.context)
File "/usr/lib/python2.6/dist-packages/schooltool/gradebook/browser/report_card.py", line 332, in deployTerm
  worksheet = root.templates[self.request['reportWorksheet']]
File "/usr/lib/python2.6/dist-packages/zope/publisher/base.py", line 334, in __getitem__
  raise KeyError(key)

[Tom Hoffman (tom-hoffman)]

If this is the same as the other bug report from yesterday, we should *really* fix this and push the change.

[Gediminas Paulauskas (menesis)]

Should say that there are no templates and not allow deploying. Provide a link to "Report sheet templates" management page.