wanted: push :BIG-ENDIAN to *FEATURES*

Bug #901661 reported by Luís Oliveira on 2011-12-08
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

The attached patch pushes :big-endian to *features* when appropriate. I offer three rationales:

1. Correctness. :big-endian and :little-endian are not the only possible endianness modes, although that is admittedly rather hypothetical.

2. Practicality. trivial-features[1] decided to push :big-endian (mostly because CCL did it), a handful of libraries depend on that and we want to turn trivial-features into a no-op some day.

3. Style. If big endian is The One True Endianness, then one could argue that using #+big-endian and #-big-endian is nicer than the alternative. :-)

[1] http://cliki.net/trivial-features

Luís Oliveira (luismbo) wrote :
Nikodemus Siivola (nikodemus) wrote :

Looks good to me, except for missing a commit message...

Changed in sbcl:
status: New → In Progress
Nikodemus Siivola (nikodemus) wrote :

commit 32d3b398d33736e61b51a14afca8c14decec4437
Author: Luis Oliveira <email address hidden>
Date: Thu Dec 8 16:56:01 2011 +0200

    explicit :BIG-ENDIAN feature

     Instead of implying big-endianness by lack of the :LITTLE-ENDIAN feature,
     make it explicit.

Changed in sbcl:
status: In Progress → Fix Committed
tags: removed: review
Changed in sbcl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers