in-file function type derivation violates safety

[Nikodemus Siivola]

File-compiling the following and calling QUUX returns "foo" instead of signalling a type-error.

(declaim (optimize safety))

(defun foo ()
  (cons t t))

(defun bar ()
  (let ((cons (foo)))
    (setf (car cons) 3)
    cons))

(defun quux ()
  (eval `(locally (declare (optimize safety))
           (setf (fdefinition 'foo) (lambda () (copy-seq "foobar")))
           (bar))))

[Nikodemus Siivola (nikodemus)]

Marking this as "high" due to heap corruption potential.

[Nikodemus Siivola (nikodemus)]

Attached patch is my current status on this. Pending addition of tests and more testing, I plan to commit this soonish.

The basic approach is to use ASSERT-LVAR-TYPE instead of DERIVE-NODE-TYPE for derived untrusted calls.

[Nikodemus Siivola (nikodemus)]

In 1.0.43.57.