dirent broken on x86-64/darwin

[Cyrus Harmon]

something about dirent is hosed on x86-64/darwin on SBCL 1.0.39.10 (and earlier):

* (let ((dir (sb-posix:opendir "/"))
        (sb-alien::*default-c-string-external-format* :latin-1))
    (unwind-protect
       (block dir-loop
         (loop for dirent = (sb-posix:readdir dir)
               until (sb-alien:null-alien dirent)
               when (not (stringp (sb-posix:dirent-name dirent)))
                 do (return-from dir-loop nil)
               finally (return t
      (sb-posix:closedir dir)))

T
*
(let ((dir (sb-posix:opendir "/")))
  (unwind-protect
       (block dir-loop
         (loop for dirent = (sb-posix:readdir dir)
            until (sb-alien:null-alien dirent)
            when (not (stringp (print (sb-posix:dirent-name dirent))))
            do (return-from dir-loop nil)
            finally (return t)))
    (sb-posix:closedir dir)))

"."
"DS_Store"
":
"
""
""
"ee"
"00"
"e"
""
"00"
"ores"
""
"eveloper"
"`"
"ome"
""
""
debugger invoked on a SB-INT:C-STRING-DECODING-ERROR in thread #<THREAD
                                                                 "initial thread" RUNNING
                                                                 {100371F841}>:
  c-string decoding error (:external-format :UTF-8):
    the octet sequence 4 cannot be decoded.

Type HELP for debugger help, or (SB-EXT:QUIT) to exit from SBCL.

restarts (invokable by number or by possibly-abbreviated name):
  0: [ABORT] Exit debugger, returning to top level.

(SB-INT:C-STRING-DECODING-ERROR :UTF-8 4)
0]

[Luís Oliveira (luismbo)]

Some cross-checking with Osicat (which works fine) seems to indicate that the DIRENT struct definition is correct and the problem lies with readdir(). Calling readdir$INODE64() instead seems to fix the problem.

[Cyrus Harmon (ch-launchpad)]

The first test up above got messed up. It should be:

(let ((dir (sb-posix:opendir "/"))
      (sb-alien::*default-c-string-external-format* :latin-1))
  (unwind-protect
       (block dir-loop
         (loop for dirent = (sb-posix:readdir dir)
            until (sb-alien:null-alien dirent)
            when (not (stringp (sb-posix:dirent-name dirent)))
            do (return-from dir-loop nil)
            finally (return t)))
    (sb-posix:closedir dir)))

[Cyrus Harmon (ch-launchpad)]

it's not dirent that's broken, so much as readdir. fix committed in 1.0.39.11.