run-sbcl.sh and some other scripts don't have execute permission set

Bug #528796 reported by sidney
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SBCL
Fix Released
Low
Unassigned

Bug Description

Some of the *.sh files have their execute bits set in the CVS repository and some, such as run-sbcl.sh do not. This is true of both files that are checked out from CVS and the files in the binary distribution tar for Mac OS X that I looked at. I didn't check other binary distributions.

I noticed this when I tried to install MCLIDE for use with sbcl. The current beta will only work if it is configured to point to run-sbcl.sh as the way to launch sbcl, as opposed to /usr/local/bin/sbcl. That's because it assumes a shell script rather than a binary executable. Fixing that in MCLIDE is difficult because there is not a good way to execute a file that might be a binary executable or a shell script without its execute permission set. I think the correct thing to do is to distribute the shell scripts with execute permissions set.

When a file is checked out from CVS it gets execute permission if the underlying file,v in the repository has its execute bit set. From what I have read, the only way to make a file executable if it was not initially checked to CVS as such is to chmod the file,v file. I was unable to determine how to do that on Sourceforge, so there may not be a good solution to this in the CVS repository. However the scripts that make the distribution tarballs, both source and binary, could be fixed to make the shell scripts executable independent of changing it in the CVS repository.

Changed in sbcl:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Burton Samograd (burton-samograd) wrote :

Would this not be as simple as a 'chmod +x *.sh' in the toplevel directory and then a commit and push now that we're using git?

Revision history for this message
Attila Lendvai (attila-lendvai) wrote :

this is still the case, although someone with the commit bit got annoyed enough by run-sbcl.sh and set it +x.

also note that some .sh's are called from toplevel .sh scripts, so they don't need the +x bit.

Stas Boukarev (stassats)
Changed in sbcl:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.