sb-simple-streams clobbers OPEN's type incompatibly

[Richard M Kreuter]

The DEFKNOWN for OPEN in contrib/sb-simple-streams/fndb.lisp clobbers the default one, and restricts EXTERNAL-FORMAT to KEYWORD. (It looks like this has "always" been a bug since cons-typed external-format arguments came along.)

Patch attached; it updates the sb-simple-streams DEFKNOWN to extend the options of the default one, and adds comments in src/compiler/fndb.lisp at each DEFKNOWN that sb-simple-streams overwrites.

[Douglas Katzman (dougk)]

I think I'd prefer OPEN not to do the clobbering, because we've already given it the :CLASS and possibly :OVERLAPPED keyword. And it is sufficiently complicated that one defknown is better than two. The others are less worrisome to clobber. I'll revise your patch a little and commit it

[Douglas Katzman (dougk)]

Hmm, is it an accident that the defknown in simple-streams also adds &ALLOW-OTHER-KEYS?
i.e. does the simple-streams protocol allow you pass random k/v pairs to OPEN?
Maybe it is better to not make that the default because allowing slop by default is not good.