ADD-DIRECT-SUBCLASS: duplicate CLASSOID-SUBCLASSES

[Michał "phoe" Herda]

https://github.com/sbcl/sbcl/blob/532b885acb3da5bf927b600f05d568507075ae3c/src/pcl/std-class.lisp#L183-L184

(defmethod add-direct-subclass ((class class) (subclass class))
  (with-slots (direct-subclasses) class
    (with-world-lock ()
      (pushnew subclass direct-subclasses :test #'eq)
      (let ((layout (class-wrapper subclass)))
        (when layout
          (let* ((classoid (layout-classoid layout)))
            (dovector (super-layout (layout-inherits layout))
              (let* ((super (layout-classoid super-layout))
                     (subclasses (or (classoid-subclasses super)
                                     (or (classoid-subclasses super) ;; isn't this NIL at this point?
                                         (setf (classoid-subclasses super)
                                               (make-hash-table :hash-function #'type-hash-value
                                                                :test 'eq
                                                                :synchronized t))))))
                (when subclasses
                  (setf (gethash classoid subclasses) layout))))))))
    subclass))

[Douglas Katzman (dougk)]

Without an example, I don't know what you're trying to say.
Fixed by https://sourceforge.net/p/sbcl/sbcl/ci/dd4eacbbc5 maybe ?

[Michał "phoe" Herda (phoe-krk)]

Sorry. I meant these two lines:

                     (subclasses (or (classoid-subclasses super)
                                     (or (classoid-subclasses super)

When I looked at the code, it seemed to me that the doubly-nested call (OR (CLASSOID-SUBCLASSES SUPER) ...) is probably unnecessary.

The current master branch no longer has this code block, so this bugticket no longer applies.