build failures on windows

Bug #1680622 reported by 3b on 2017-04-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SBCL
Undecided
Unassigned

Bug Description

On 1.3.16.60, 64bit windows build fails due to "#include <pthread.h>" in src/runtime/hopscotch.c conflicting with sbcl's "pthreads_win32.h". (from 8333dce45f777ae33385cfe3269dcb31fcc83d20 "8333dce45 ("Reduce pinned object table size, part 1 of 2.")

After replacing <pthread.h> with "pthreads_win32.h", it fails at make-target-2.sh with

fatal error encountered in SBCL pid 4500(tid 0000000000346410):
no size function for object at 0000001001BA70D0 (widetag 0x1)

due to 1LU in src/runtime/runtime.h being 32 bits on 64bit windows (from e427145862cb8df9757016a42019a8a3f4b03f0 "Optimize is_cons_half()").

replacing with 1LLU allows build to complete

Stas Boukarev (stassats) wrote :

1LU should be (uword_t)1

3b (00003b) wrote :

same header conflict in hopscotch.o in current version (tried 5a6585009), looks like the patch tries to check LISP_FEATURE_WIN32 before anything defines it.

Stas Boukarev (stassats) wrote :

In ff39cbeb8631185ec62f57463b789385371df89e

Changed in sbcl:
status: New → Fix Committed
Stas Boukarev (stassats) on 2017-04-28
Changed in sbcl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers