contrib/asdf fails parallel build since 1.2.3

Bug #1434768 reported by Nikhil Benesch on 2015-03-21
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Homebrew is currently stuck at v1.2.2 of SBCL [0] because 1.2.3 broke parallel builds. I've tracked the cause to the commit that upgrades to asdf 3.1.3 [1], which introduces a race condition in contrib/asdf/Makefile:

  attempt to load an empty FASL file:


  WARNING! Some of the contrib modules did not build successfully or pass
  their self-tests. Failed contribs:"

As best as I can tell, the $(ASDF_FASL) task has an undeclared dependency on the $(UIOP_FASL) task. Make doesn't know about this, runs the tasks in parallel, and the test fails.

To reproduce:

    1. Find a box with multiple cores. (Probably.)
    2. Instruct Make to parallelize the build: MAKEFLAGS=-j2
    3. Compile like normal.

The race condition occurs reliably for me on a 4-core MacBook Pro with -j4 and SBCL 1.2.9.

NOTE: This parallelization is unrelated to #1010646 [2].


Nikhil Benesch (nikhil-benesch) wrote :

Thank you; I've merged this patch as commit


Changed in sbcl:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers