(COND ()) error message tweaking

[Pascal J. Bourguignon]

On (COND ()) SBCL reports: COND clause is not a list: NIL
this is not correct, nil IS a list.
The error message should be: COND clause is invalid, it should be an non-empty list.

Tested on sbcl 1.1.1.0.debian

[Erik Krisztián Varga (erik-varga256)]

Added a patch. This displays a different message when clause is NIL.

[Stas Boukarev (stassats)]

Myabe instead of checking for NIL just say that it is not a CONS? And for the patch to get applied directly you need to:
a) mention the ticket in the commit message
b) add a description to the NEWS file, mentioning the ticket number.
See other commits for examples.

[Christophe Rhodes (csr21-cantab)]

Stas Boukarev <email address hidden> writes:

> Myabe instead of checking for NIL just say that it is not a CONS? And
> for the patch to get applied directly you need to:
> a) mention the ticket in the commit message
> b) add a description to the NEWS file, mentioning the ticket number.
> See other commits for examples.

For extra style points, you could use a simple-type-error to indicate
the expected type of the datum.

Christophe

[Erik Krisztián Varga (erik-varga256)]

Yeah, I guess that makes more sense than handling NIL separately. Here's an updated patch, with the ticket number added.
For this to get applied, should I push it into the repo myself?

[Stas Boukarev (stassats)]

Applied in caa5c21b29bbe633dbc72f23677412213080f314, thanks. And git format-patch is the best way to provide patches. And you copied a typo from a commit message, it should be lp#1254511, not lp1254511.

[Erik Krisztián Varga (erik-varga256)]

All right, thanks. Sorry about the typo, I checked another commit to see what to write and thought that was the required format.