Use gensyms in typed struct accessor functions

Bug #1171646 reported by Matt Novenstern on 2013-04-22
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Fixes the FIXME in src/code/defstruct.lisp which said that gensyms should be used in the argument lists for slot accessor functions of the struct so that they wouldn't accidentally have the same name as a special variable and cause strange behavior.

Making a typed structure and setting/getting the slot seems to work, as does the test suite.

Paul Khuong (pvk) wrote :

The FIXME is wrong, not the code.

Matt Novenstern (fisxoj) wrote :

Then, maybe this patch is more appropriate...

Sure. Should be applied as soon as we're out of freeze.

Changed in sbcl:
importance: Undecided → Low
status: New → Triaged
assignee: nobody → Paul Khuong (pvk)
status: Triaged → In Progress
Paul Khuong (pvk) on 2013-05-18
Changed in sbcl:
status: In Progress → Fix Committed
assignee: Paul Khuong (pvk) → nobody
Stas Boukarev (stassats) on 2013-06-03
Changed in sbcl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers