Steel Bank Common Lisp

Unexpected-failure in threads.impure test

Reported by zmyrgel on 2013-03-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SBCL
Undecided
Unassigned

Bug Description

$ sh run-tests.sh threads.impure.lisp
/running tests on '/home/zmyrgel/git/sbcl/tests/../src/runtime/sbcl --core /home/zmyrgel/git/sbcl/tests/../output/sbcl.core --noinform --no-sysinit --no-userinit --noprint --disable-debugger'
// Running pure tests (#<FUNCTION RUN-TESTS::LOAD-TEST>)
// Running pure tests (#<FUNCTION RUN-TESTS::CLOAD-TEST>)
// Running impure tests (#<FUNCTION RUN-TESTS::LOAD-TEST>)
// Running /home/zmyrgel/git/sbcl/tests/threads.impure.lisp
::: Running (:THREADS :TRIVIA)
::: Success (:THREADS :TRIVIA)
::: Running (:WITH-MUTEX :BASICS)
::: Success (:WITH-MUTEX :BASICS)
::: Running (:WITH-MUTEX :TIMEOUT)
::: UNEXPECTED-FAILURE (:WITH-MUTEX :TIMEOUT)
    due to #<SIMPLE-ERROR "Not supported in unithread builds." {10035C8683}>:
        "Not supported in unithread builds."
::: Running (:INTERRUPT-THREAD :BASICS :NO-UNWINDING)
::: Success (:INTERRUPT-THREAD :BASICS :NO-UNWINDING)
::: Running (:INTERRUPT-THREAD :DEFERRABLES-BLOCKED)
::: Success (:INTERRUPT-THREAD :DEFERRABLES-BLOCKED)
::: Running (:INTERRUPT-THREAD :DEFERRABLES-UNBLOCKED)
::: Success (:INTERRUPT-THREAD :DEFERRABLES-UNBLOCKED)
::: Running (:INTERRUPT-THREAD :NLX)
::: Success (:INTERRUPT-THREAD :NLX)
// Running impure tests (#<FUNCTION RUN-TESTS::CLOAD-TEST>)
// Running impure tests (#<FUNCTION RUN-TESTS::SH-TEST>)

Finished running tests.
All tests succeeded
ok
//apparent success (reached end of run-tests.sh normally)
Sun Mar 3 11:32:23 EET 2013
$

Here's simple patch to fix this:

diff --git a/tests/threads.impure.lisp b/tests/threads.impure.lisp
index ddd1ef0..e36ea48 100644
--- a/tests/threads.impure.lisp
+++ b/tests/threads.impure.lisp
@@ -37,7 +37,8 @@
     (with-mutex (mutex)
       mutex)))

-(with-test (:name (:with-mutex :timeout))
+(with-test (:name (:with-mutex :timeout)
+ :skipped-on '(not :sb-thread))
   (let ((m (make-mutex)))
     (with-mutex (m)
       (assert (null (join-thread (make-thread

Stas Boukarev (stassats) wrote :

commit e241757954fbb4ef0d7b97597d65bfc31dbd60ba
Author: Stas Boukarev <email address hidden>
Date: Sun Mar 3 15:09:40 2013 +0400

    Fix a test-case in threads.impure.lisp on -sb-thread.

    A test was using make-thread without ensuring that sb-thread is enabled.

Changed in sbcl:
status: New → Fix Committed
Stas Boukarev (stassats) on 2013-03-31
Changed in sbcl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers