Aggregators should not provide .application files for child OA

[Marcus Tomlinson]

During the confusion of log-in buttons not working in aggregator scopes, a (incorrect) work-around to the problem was to also add the aggregator as a client to the online service (hence you see both FB Photos and Photos under the Facebook account).

Aggregator scopes should not be registering themselves as clients to services, only the scopes directly requiring access should.

Therefore, aggregator scopes need to be updated to remove their .application files so that we no longer see multiple entries in OA settings for one OA client.

[Kyle Nitzsche (knitzsche)]

There is one issue I think:

I removed the application file from photos agg.

Launched it and saw login button for FB as expected. Tapped it and completed log in successfully and was returned to scope.

Refreshed the scope.

Problem:
 * login button still present

Expectation:
* normal logged in results display.

Note: I manually wen to Settings > Accounts > Facebook and saw the FB Photos App. I was not enabled. I enabled it. After doing this, the Photos agg scope shows FB photos.

I don't think the user should be required to navigated to settings to enable the app they just logged into. They should be returned to the agg scope and it should be enabled, so they just see results.

[Kyle Nitzsche (knitzsche)]

fixed with com.canonical.scopes.photos_1.29_armhf.click for savilerow

(I assume the above issue I mentioned has nothing to do with the scope.)

[Kyle Nitzsche (knitzsche)]

We cannot have this behavior mentioned in comment #1 get into production, so I am going to pull com.canonical.scopes.photos_1.29_armhf.click

We will need to push a click when this new issue is fixed.

Also, Today agg scope will need the change too.

[Marcus Tomlinson (marcustomlinson)]

Kyle, please ensure that you have the following package versions installed:

unity-plugin-scopes : 0.5.4+15.04.20150206.1~rtm-0ubuntu1
libunity-scopes3 : 0.6.9+15.04.20150126~rtm-0ubuntu1

if not, please upgrade and try again, Photos Scope v1.29 works fine for me.

[Kyle Nitzsche (knitzsche)]

here is what I have:
phablet@ubuntu-phablet:~$ apt-cache policy unity-plugin-scopes
unity-plugin-scopes:
  Installed: 0.5.4+15.04.20150126~rtm.is.0.5.4+15.04.20150120~rtm-0ubuntu1

^^^ not the latest

phablet@ubuntu-phablet:~$ apt-cache policy libunity-scopes3
libunity-scopes3:
  Installed: 0.6.9+15.04.20150126~rtm-0ubuntu1

I'll upgrade and report back.

[Kyle Nitzsche (knitzsche)]

upgrading unity-plugin-scopes to the stated version did not fix the issue. I'll wipe and reflash and see if that does it.

[Kyle Nitzsche (knitzsche)]

after reflash with --wipe, photos v1.29 works as expected regarding FB OA. That is, the scope displays the login button, I tap it, I log in, I return to scope, and fb photos display in photos agg, with no need to manually enable the app in Settings > Accounts

[Kyle Nitzsche (knitzsche)]

I committed photos v1.29 to our clicks branch (the starting point for inclusion in images).

Next up: Today scope needs the same fix.

[Kyle Nitzsche (knitzsche)]

today scope now has same fix in clicks branch with com.canonical.scopes.dashboard_1.6_all.click

[Yuan-Chen Cheng (ycheng-twn)]

mark as fix release since it's probably be.