properties-cpp clashes with Qt "slots" keyword

Bug #1329743 reported by Michał Karnicki
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
The Savilerow project
Fix Released
Undecided
Unassigned
qtcreator-plugin-ubuntu
Invalid
Undecided
Unassigned
properties-cpp (Ubuntu)
Fix Released
Undecided
Marcus Tomlinson

Bug Description

See problem here:

http://paste.ubuntu.com/7638421/

This was caused by properties-cpp dependency added in unity-scope-api. This clashes with the "slots" keyword in Qt when building a scope that uses Qt slots.

The src/CMakeLists.txt should contain:

add_definitions(-DQT_NO_KEYWORDS)

Tags: scope-dev

Related branches

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

As soon as the linked branch lands in distro, you should no longer need to add "add_definitions(-DQT_NO_KEYWORDS)" to CMakeLists.txt.

Changed in properties-cpp:
assignee: nobody → Marcus Tomlinson (marcustomlinson)
status: New → In Progress
Changed in savilerow:
status: New → In Progress
Changed in qtcreator-plugin-ubuntu:
status: New → In Progress
Changed in savilerow:
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in qtcreator-plugin-ubuntu:
assignee: nobody → Marcus Tomlinson (marcustomlinson)
summary: - New scope template needs to allow Qt slots
+ properties-cpp clashes with Qt "slots" keyword
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

This is a bug in properties-cpp not "qtcreator-plugin-ubuntu" nor "The Savilerow project". Will try get this landed soon.

Changed in savilerow:
status: In Progress → Invalid
Changed in qtcreator-plugin-ubuntu:
status: In Progress → Invalid
assignee: Marcus Tomlinson (marcustomlinson) → nobody
Changed in savilerow:
assignee: Marcus Tomlinson (marcustomlinson) → nobody
Revision history for this message
Alex Chiang (achiang) wrote :

Marcus,

Please do not touch the status of savilerow projects. We use that to keep track of bugs that affect downstream's ability to customize upstream.

If the upstream project needs to be changed to properties-cpp, that is fine.

Thanks.

Changed in savilerow:
status: Invalid → In Progress
no longer affects: properties-cpp
Changed in properties-cpp (Ubuntu):
status: New → In Progress
assignee: nobody → Marcus Tomlinson (marcustomlinson)
Changed in properties-cpp (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package properties-cpp - 0.0.1+14.10.20140730-0ubuntu1

---------------
properties-cpp (0.0.1+14.10.20140730-0ubuntu1) utopic; urgency=low

  [ Marcus Tomlinson ]
  * Renamed "slots" to "slot_list" in signal.h as to avoid clashing with
    the "slots" Qt keyword. (LP: #1329743)
 -- Ubuntu daily release <email address hidden> Wed, 30 Jul 2014 15:09:54 +0000

Changed in properties-cpp (Ubuntu):
status: Fix Committed → Fix Released
Changed in savilerow:
status: In Progress → Invalid
status: Invalid → In Progress
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

too old

Changed in savilerow:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.