properties-cpp clashes with Qt "slots" keyword
Bug #1329743 reported by
Michał Karnicki
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Savilerow project |
Fix Released
|
Undecided
|
Unassigned | ||
qtcreator-plugin-ubuntu |
Invalid
|
Undecided
|
Unassigned | ||
properties-cpp (Ubuntu) |
Fix Released
|
Undecided
|
Marcus Tomlinson |
Bug Description
See problem here:
http://
This was caused by properties-cpp dependency added in unity-scope-api. This clashes with the "slots" keyword in Qt when building a scope that uses Qt slots.
The src/CMakeLists.txt should contain:
add_definitions
Related branches
lp:~marcustomlinson/properties-cpp/fix_qt_keyword_clash
- Thomas Voß (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 119 lines (+18/-18)1 file modifiedinclude/core/signal.h (+18/-18)
Changed in properties-cpp: | |
assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
status: | New → In Progress |
Changed in savilerow: | |
status: | New → In Progress |
Changed in qtcreator-plugin-ubuntu: | |
status: | New → In Progress |
Changed in savilerow: | |
assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
Changed in qtcreator-plugin-ubuntu: | |
assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
summary: |
- New scope template needs to allow Qt slots + properties-cpp clashes with Qt "slots" keyword |
no longer affects: | properties-cpp |
Changed in properties-cpp (Ubuntu): | |
status: | New → In Progress |
assignee: | nobody → Marcus Tomlinson (marcustomlinson) |
Changed in properties-cpp (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in savilerow: | |
status: | In Progress → Invalid |
status: | Invalid → In Progress |
To post a comment you must log in.
As soon as the linked branch lands in distro, you should no longer need to add "add_definition s(-DQT_ NO_KEYWORDS) " to CMakeLists.txt.