test_infographics_themes may break if we do not ship custom theme

[Alex Chiang]

    def test_theme_dir_in_datadirs(self):
        """
        Downstreams may customize the color scheme of the infographic on
        the welcome screen by shipping an XML file.

        This test ensures that the XML file has been properly installed
        in the system.
        """
        themefilefound = False
        data_dirs = subprocess.check_output(['initctl', 'get-env',
                                             'XDG_DATA_DIRS']).split(':')
        for dir in data_dirs:
            # We use a relative path in `themefile` because we don't
            # necessarily know the full path to the custom XDG data
            # directory. Currently, the path is set to /custom/xdg/data
            # in ubuntu-touch-customization-hooks, but that could
            # theoretically change. So use the relative path, and glom
            # it together with every XDG_DATA_DIR path we discover in
            # the environment and test for its presence. Not spectacular
            # but it works.
            #
            # Note that initctl get-env adds a \n to the end of the
            # output so we need to strip() it out
            if os.path.isfile(os.path.join(dir.strip(), themefile)):
                themefilefound = True
        self.assertTrue(themefilefound)

Based on the way this test is written, it seems like it assumes we MUST ship a custom.xml, else it will fail on the assertTrue()

What if a downstream chooses not to ship such a file? This test will then fail.

The test needs to handle that situation.

[Yuan-Chen Cheng (ycheng-twn)]

too old