[UI][EDP] Empty key value pairs for arguments are processed

Bug #1269972 reported by Trevor McKay
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sahara
Fix Released
Medium
Chad Roberts

Bug Description

When configuring a job in the UI, adding parameters or configuration values but leaving the key/value pairs empty results in empty key/value pairs being passed to savanna-api.

In some cases the savanna-api fails to filter out the empty key/value pairs and includes them in the workflow.

Tags: dashboard edp
tags: added: dashboard edp
Changed in savanna:
status: New → Confirmed
importance: Undecided → High
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna (master)

Reviewed: https://review.openstack.org/67497
Committed: https://git.openstack.org/cgit/openstack/savanna/commit/?id=c94aced255f82355dea401d1c28f004f6c5bc58b
Submitter: Jenkins
Branch: master

commit c94aced255f82355dea401d1c28f004f6c5bc58b
Author: Trevor McKay <email address hidden>
Date: Fri Jan 17 10:29:32 2014 -0500

    Ignore key/value pairs with empty keys in workflow generation

    Savanna should ignore key/value pairs with empty keys when
    generating <property> tags or equal-separated dictionary
    entries in workflow.xml.

    Partial-bug: #1269972
    Change-Id: I327d1f4ac2f5db3a2778678567b63148f41c7932

Trevor McKay (tmckay)
Changed in savanna:
status: Confirmed → Fix Committed
assignee: nobody → Trevor McKay (tmckay)
status: Fix Committed → In Progress
assignee: Trevor McKay (tmckay) → Chad Roberts (croberts)
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to savanna-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/68763

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to savanna-dashboard (master)

Reviewed: https://review.openstack.org/68763
Committed: https://git.openstack.org/cgit/openstack/savanna-dashboard/commit/?id=afbc35ce10dd02f2ccf3fcbe5869b572d44598a3
Submitter: Jenkins
Branch: master

commit afbc35ce10dd02f2ccf3fcbe5869b572d44598a3
Author: Chad Roberts <email address hidden>
Date: Thu Jan 23 15:25:59 2014 -0500

    Dashboard now ignores empty job configuration items

    The dashboard will now ignore any empty configs, params or args
    that have empty names or values.

    Partial-bug: #1269972

    Change-Id: I186e3a68b6f5c0a71e0debc375a3f7609bf3cca0

Chad Roberts (croberts)
Changed in savanna:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in savanna:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in sahara:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.