complete blueprint poc-config-object

Bug #1301020 reported by Sam Stavinoha on 2014-04-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
satori
Critical
Sam Stavinoha

Bug Description

Some references to the config object remain after the conversion to a dictionary.

6 references in satori/common/logging.py

Resulting in a traceback when trying to run satori:

Traceback (most recent call last):
  File "~/bin/satori", line 10, in <module>
    sys.exit(main())
  File "~/satori/satori/shell.py", line 219, in main
    common_logging.init_logging(config)
  File "~/satori/satori/common/logging.py", line 57, in init_logging
    if config.logconfig and os.path.isfile(config.logconfig):
AttributeError: 'dict' object has no attribute 'logconfig'

Sam Stavinoha (smlstvnh) on 2014-04-01
description: updated

Fix proposed to branch: master
Review: https://review.openstack.org/84556

Changed in satori:
status: New → In Progress

Reviewed: https://review.openstack.org/84556
Committed: https://git.openstack.org/cgit/stackforge/satori/commit/?id=54f816aa1f03c95aa2611d78f61d2800989b5c7c
Submitter: Jenkins
Branch: master

commit 54f816aa1f03c95aa2611d78f61d2800989b5c7c
Author: Samuel Stavinoha <email address hidden>
Date: Tue Apr 1 16:16:16 2014 -0500

    Fix remaining refs to the former config object

    Switch notation from

        value = d.key

    to

        value = d.get('key') # in optional cases
        value = ['key'] # in required cases

    Unittests for config dictionary make use of mock.patch.dict

    Change-Id: Ib688dd13e1e3df9a82b3f0377064be8e6c765e55
    Closes-Bug: #1301020

Changed in satori:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers