satori

System info should only be gathered if requested by the user

Bug #1295315 reported by Caleb Groom on 2014-03-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ satori
Fix Committed
High
Caleb Groom
satori poc "Proof of Concept"
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

No relevant environment variables:

$ env | grep OS_ | wc -l
       0

Satori tries to SSH into a server to get system info even though the user hasn't requested that:

$ satori waldotest.gus.io
Installing (or updating) ohai-solo on device 162.209.115.233 at 162.209.115.233:22
ssh://root@162.209.115.233:22 failed. [Errno 61] Connection refused
[Errno 61] Connection refused

BK Box (bkbox) on 2014-03-20
Changed in satori:
milestone: none → poc
status: New → Confirmed
importance: Undecided → High
BK Box (bkbox) on 2014-03-20
Changed in satori:
assignee: nobody → Caleb Groom (calebgroom)
OpenStack Infra (hudson-openstack) wrote : Fix proposed to satori (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81912

Changed in satori:
status: Confirmed → In Progress
OpenStack Infra (hudson-openstack) wrote : Fix merged to satori (master)

Reviewed: https://review.openstack.org/81912
Committed: https://git.openstack.org/cgit/stackforge/satori/commit/?id=7a11714010ac11e1745dce8dca7694ac9269ac47
Submitter: Jenkins
Branch: master

commit 7a11714010ac11e1745dce8dca7694ac9269ac47
Author: Caleb Groom <email address hidden>
Date: Thu Mar 20 15:25:53 2014 -0500

    Only attempt remote logins if directed by the user

    Since the system info plugin was defaulting to ohai-solo this
    commit moves the check for the user's intention up.

    Change-Id: Iccbbd882371131c930f7a951cc88c5628c290464
    Closes-Bug: 1295315

Changed in satori:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers