Satori discovery should not fail if one resource cannot be discovered (like DNS)

Bug #1293670 reported by Ziad Sawalha on 2014-03-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
satori
Undecided
Ziad Sawalha

Bug Description

If whois fails, but DNS resolution works (ex. hosts file entry), then satori should still run discovery on the IP address.

Changed in satori:
assignee: nobody → Ziad Sawalha (ziad-sawalha)

Reviewed: https://review.openstack.org/82187
Committed: https://git.openstack.org/cgit/stackforge/satori/commit/?id=d649f19680a0dae223de4318e4607e0d3b96807e
Submitter: Jenkins
Branch: master

commit d649f19680a0dae223de4318e4607e0d3b96807e
Author: BK Box <email address hidden>
Date: Fri Mar 21 15:24:28 2014 -0500

    Add exception `SatoriInvalidDomain`

    When `domain_info` is passed an invalid domain, it would attempt to
    parse the registered domain and eventually pass a blank string to
    `pythonwhois.get_whois`. This causes an exception of "No root WHOIS
    server found for TLD." This is a valid exception, but we should not make
    it this far to get this exception.

    Instead, this patch will raise an exception of `SatoriInvalidDomain` if
    domain_info attempted to be used with an invalid domain.

    Change-Id: Ie30b9a01b39d92d8bfeb7f3a80d333fa4bb30d49
    Closes-Bug: #1295391
    Closes-Bug: #1293670

Changed in satori:
status: New → Fix Committed
description: updated
summary: - Satori does not handle IP addresses as an input
+ Satori discovery should not fail if one resource cannot be discovered
+ (like DNS)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers